Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Silence Rollup warnings regarding source maps & use directives #150

Merged
merged 1 commit into from
Jan 1, 2025
Merged

refactor: Silence Rollup warnings regarding source maps & use directives #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,23 @@ function preactPlugin({
build: {
rollupOptions: {
onwarn(warning, warn) {
// Silence Rollup's module-level directive warnings -- they're likely
// to all come from `node_modules` (RSCs) and won't be actionable.
if (warning.code === "MODULE_LEVEL_DIRECTIVE") return;
// Silence Rollup's module-level directive warnings re:"use client".
// They're likely to come from `node_modules` and won't be actionable.
if (
warning.code === "MODULE_LEVEL_DIRECTIVE" &&
warning.message.includes("use client")
Comment on lines -156 to +160
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure copying Vite's React plugin and restricting this to only use client is a good idea -- users should be warned if a use server shows up somewhere.

)
return;
// ESBuild seemingly doesn't include mappings for directives, causing
// Rollup to emit warnings about missing source locations. This too is
// likely to come from `node_modules` and won't be actionable.
// evanw/esbuild#3548
if (
warning.code === "SOURCEMAP_ERROR" &&
warning.message.includes("resolve original location") &&
warning.pos === 0
)
return;
warn(warning);
},
},
Expand Down
Loading