Resolve included libraries from dependencies.json #4
Conversation
|
@dgirardi Here is a quick fix to allow Prebid Packager to handle if a module has dependencies. I am sure there is a better way to do this but I had to quickly throw something together! |
There was a problem hiding this comment.
LGTM with the caveat that I haven't looked at the details of this packager (e.g. manifest is a view on the files generated by the build I assume?) but the use of dependencies.json looks correct.
FYI, the prebid.org download page runs gulp build once per version, then gulp bundle to generate bundles (with different modules etc) which is relatively inexpensive.
|
Yeah, I think it is time to move our stuff to utilize bundle now in Prebid. I think it supersedes this use case. Going to merge this for now and do a release. Then get off of it! Don't think you need to get into the weeds of the packager haha. |
As per the convo in prebid/Prebid.js#8599 (comment)
We need to update prebid packager to handle if a included module has library dependencies.
This was a quick fix to resolve those which need to be added.