-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebid core: improve library support; make AnalyticsAdapter a library #8599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the build file and saw the duplicate references for the analytics adapter code only appeared once, instead of dozens of time.
So this appears to working from what I can tell. Nice work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Looks like the Our process uses Prebid Packager https://github.com/prebid/Prebid.js-packager which I am thinking is the problem. Since src/analyticsAdapter.js is not inside the generated rubiconAnalyticsAdapter.js, prebid packager needs to include it in the build. Guessing it does not handle libraries or something. I'll continue to look into it. |
Yeah, so now looks like we need to update prebid packager to correctly include the necessary I see So this needs to be included in the build. As I think we are the only ones working with prebid packager, I will try and fix this. |
@robertrmartinez the build now generates a |
@dgirardi I whipped up something real quick which "solves" this. I know it could be written better / cleaner of course, but unfortunately I am slammed at the moment. I guess we should prob get off of this prebid packager sometime maybe, but it makes our system run quicker since we do not have to run gulp build every time we build a prebid wrapper. |
…prebid#8599) * Automatically resolve libraries and their dependencies * Move AnalyticsAdapter under libraries
…prebid#8599) * Automatically resolve libraries and their dependencies * Move AnalyticsAdapter under libraries
Type of change
Description of change
This:
import
symbols from it;AnalyticsAdapter.js
a library, so that it can be shared when multiple analytics adapters are included in the build.Other information
Closes #7936
Original library PR: #8527
Minor docs update: prebid/prebid.github.io#3863