Skip to content

Commit

Permalink
Add reserve parameter + remove duplicate (#413)
Browse files Browse the repository at this point in the history 
remove duplicate line in AppNexus adapter
  • Loading branch information
@benjaminclot
benjaminclot authored and Matt Kendall committed Jun 16, 2016
1 parent dc34f6c commit 08f5bc4
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/adapters/appnexus.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ AppNexusAdapter = function AppNexusAdapter() {
utils.logMessage('appnexus.callBids: "memberId" will be deprecated soon. Please use "member" instead');
}

jptCall = utils.tryAppendQueryString(jptCall, 'code', inventoryCode);
jptCall = utils.tryAppendQueryString(jptCall, 'code', inventoryCode);

//sizes takes a bit more logic
Expand Down

3 comments on commit 08f5bc4

@ehoch
Copy link
Contributor

@ehoch ehoch commented on 08f5bc4 Jun 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkendall07 @benjaminclot I see mention of adding the reserve parameter, but it didn't make it into this PR. Is this something we could get added?

@mkendall07
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It already works if you add it to the params:
{ bidder: 'appnexus', params: { placementId: '123', reserve : '2.00' } }

@ehoch
Copy link
Contributor

@ehoch ehoch commented on 08f5bc4 Jun 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks @mkendall07

Please sign in to comment.