Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate line in AppNexus adapter #413

Merged
merged 2 commits into from
Jun 16, 2016

Conversation

benjaminclot
Copy link
Contributor

  • added reserve price parameter
  • removed duplicate jptCall = utils.tryAppendQueryString(jptCall, 'code', inventoryCode);

+ added reserve price parameter
- removed duplicate `jptCall = utils.tryAppendQueryString(jptCall, 'code', inventoryCode);`
@mkendall07
Copy link
Member

@benjaminclot
You actually don't need this code to be added. You can already add reserve into the AppNexus bidder params and it is automatically added to the query. Any key/value will work: https://github.com/benjaminclot/Prebid.js/blob/4e0e46c9cfc035e46e7d10a66b48ca8b212b7f37/src/adapters/appnexus.js#L117

@benjaminclot
Copy link
Contributor Author

My bad, I didn't see this part.
But the duplicate line is still valid I guess :)

@mkendall07
Copy link
Member

Yep. If you remove the other code I'll merge.

@benjaminclot
Copy link
Contributor Author

Done.

@mkendall07 mkendall07 changed the title Add reserve parameter + remove duplicate remove duplicate line in AppNexus adapter Jun 16, 2016
@mkendall07 mkendall07 merged commit 08f5bc4 into prebid:master Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants