Updated Sovrn Bid Adaptor for MultiSized and added Error Call Home. (#…

…3237) * Updated Bid Adaptor for MultiSized and added Error Call Home * Updated to conform with prebid requirements * added missing this * Added tests for more coverage * simplified error object for edge 15
prebid · Nov 15, 2018 · 259af19 · 259af19
1 parent 3320a83
commit 259af19
Show file tree

Hide file tree

Showing 2 changed files with 266 additions and 90 deletions.
diff --git a/modules/sovrnBidAdapter.js b/modules/sovrnBidAdapter.js
@@ -1,7 +1,9 @@
-import * as utils from 'src/utils';
-import { registerBidder } from 'src/adapters/bidderFactory';
-import { BANNER } from 'src/mediaTypes';
-import { REPO_AND_VERSION } from 'src/constants';
+import * as utils from 'src/utils'
+import { registerBidder } from 'src/adapters/bidderFactory'
+import { BANNER } from 'src/mediaTypes'
+import { REPO_AND_VERSION } from 'src/constants'
+const errorUrl = 'https://pcb.aws.lijit.com/c'
+let errorpxls = []
 
 export const spec = {
   code: 'sovrn',
@@ -22,48 +24,59 @@ export const spec = {
    * @return object of parameters for Prebid AJAX request
    */
   buildRequests: function(bidReqs, bidderRequest) {
-    const loc = utils.getTopWindowLocation();
-    let sovrnImps = [];
-    let iv;
-    utils._each(bidReqs, function (bid) {
-      iv = iv || utils.getBidIdParameter('iv', bid.params);
-      sovrnImps.push({
-        id: bid.bidId,
-        banner: { w: 1, h: 1 },
-        tagid: String(utils.getBidIdParameter('tagid', bid.params)),
-        bidfloor: utils.getBidIdParameter('bidfloor', bid.params)
+    try {
+      const loc = utils.getTopWindowLocation();
+      let sovrnImps = [];
+      let iv;
+      utils._each(bidReqs, function (bid) {
+        iv = iv || utils.getBidIdParameter('iv', bid.params);
+        bid.sizes = ((utils.isArray(bid.sizes) && utils.isArray(bid.sizes[0])) ? bid.sizes : [bid.sizes])
+        bid.sizes = bid.sizes.filter(size => utils.isArray(size))
+        const processedSizes = bid.sizes.map(size => ({w: parseInt(size[0], 10), h: parseInt(size[1], 10)}))
+        sovrnImps.push({
+          id: bid.bidId,
+          banner: {
+            format: processedSizes,
+            w: 1,
+            h: 1,
+          },
+          tagid: String(utils.getBidIdParameter('tagid', bid.params)),
+          bidfloor: utils.getBidIdParameter('bidfloor', bid.params)
+        });
       });
-    });
-    const sovrnBidReq = {
-      id: utils.getUniqueIdentifierStr(),
-      imp: sovrnImps,
-      site: {
-        domain: loc.host,
-        page: loc.host + loc.pathname + loc.search + loc.hash
-      }
-    };
+      const sovrnBidReq = {
+        id: utils.getUniqueIdentifierStr(),
+        imp: sovrnImps,
+        site: {
+          domain: loc.host,
+          page: loc.host + loc.pathname + loc.search + loc.hash
+        }
+      };
 
-    if (bidderRequest && bidderRequest.gdprConsent) {
-      sovrnBidReq.regs = {
-        ext: {
-          gdpr: +bidderRequest.gdprConsent.gdprApplies
-        }};
-      sovrnBidReq.user = {
-        ext: {
-          consent: bidderRequest.gdprConsent.consentString
-        }};
-    }
+      if (bidderRequest && bidderRequest.gdprConsent) {
+        sovrnBidReq.regs = {
+          ext: {
+            gdpr: +bidderRequest.gdprConsent.gdprApplies
+          }};
+        sovrnBidReq.user = {
+          ext: {
+            consent: bidderRequest.gdprConsent.consentString
+          }};
+      }
 
-    let url = `//ap.lijit.com/rtb/bid?` +
-      `src=${REPO_AND_VERSION}`;
-    if (iv) url += `&iv=${iv}`;
+      let url = `//ap.lijit.com/rtb/bid?` +
+        `src=${REPO_AND_VERSION}`;
+      if (iv) url += `&iv=${iv}`;
 
-    return {
-      method: 'POST',
-      url: url,
-      data: JSON.stringify(sovrnBidReq),
-      options: {contentType: 'text/plain'}
-    };
+      return {
+        method: 'POST',
+        url: url,
+        data: JSON.stringify(sovrnBidReq),
+        options: {contentType: 'text/plain'}
+      }
+    } catch (e) {
+      new LogError(e, {bidReqs, bidderRequest}).append()
+    }
   },
 
   /**
@@ -72,48 +85,99 @@ export const spec = {
    * @return {Bid[]} An array of formatted bids.
   */
   interpretResponse: function({ body: {id, seatbid} }) {
-    let sovrnBidResponses = [];
-    if (id &&
-      seatbid &&
-      seatbid.length > 0 &&
-      seatbid[0].bid &&
-      seatbid[0].bid.length > 0) {
-      seatbid[0].bid.map(sovrnBid => {
-        sovrnBidResponses.push({
-          requestId: sovrnBid.impid,
-          cpm: parseFloat(sovrnBid.price),
-          width: parseInt(sovrnBid.w),
-          height: parseInt(sovrnBid.h),
-          creativeId: sovrnBid.crid || sovrnBid.id,
-          dealId: sovrnBid.dealid || null,
-          currency: 'USD',
-          netRevenue: true,
-          mediaType: BANNER,
-          ad: decodeURIComponent(`${sovrnBid.adm}<img src="${sovrnBid.nurl}">`),
-          ttl: 60
+    try {
+      let sovrnBidResponses = [];
+      if (id &&
+        seatbid &&
+        seatbid.length > 0 &&
+        seatbid[0].bid &&
+        seatbid[0].bid.length > 0) {
+        seatbid[0].bid.map(sovrnBid => {
+          sovrnBidResponses.push({
+            requestId: sovrnBid.impid,
+            cpm: parseFloat(sovrnBid.price),
+            width: parseInt(sovrnBid.w),
+            height: parseInt(sovrnBid.h),
+            creativeId: sovrnBid.crid || sovrnBid.id,
+            dealId: sovrnBid.dealid || null,
+            currency: 'USD',
+            netRevenue: true,
+            mediaType: BANNER,
+            ad: decodeURIComponent(`${sovrnBid.adm}<img src="${sovrnBid.nurl}">`),
+            ttl: 60
+          });
         });
-      });
+      }
+      return sovrnBidResponses
+    } catch (e) {
+      new LogError(e, {id, seatbid}).append()
     }
-    return sovrnBidResponses;
   },
 
   getUserSyncs: function(syncOptions, serverResponses, gdprConsent) {
-    if (serverResponses && serverResponses.length !== 0 && syncOptions.iframeEnabled) {
-      let iidArr = serverResponses.filter(rsp => rsp.body && rsp.body.ext && rsp.body.ext.iid)
-        .map(rsp => { return rsp.body.ext.iid });
-      let consentString = '';
-      if (gdprConsent && gdprConsent.gdprApplies && typeof gdprConsent.consentString === 'string') {
-        consentString = gdprConsent.consentString
+    try {
+      let tracks = []
+      if (serverResponses && serverResponses.length !== 0 && syncOptions.iframeEnabled) {
+        let iidArr = serverResponses.filter(rsp => rsp.body && rsp.body.ext && rsp.body.ext.iid)
+          .map(rsp => { return rsp.body.ext.iid });
+        let consentString = '';
+        if (gdprConsent && gdprConsent.gdprApplies && typeof gdprConsent.consentString === 'string') {
+          consentString = gdprConsent.consentString
+        }
+        if (iidArr[0]) {
+          tracks.push({
+            type: 'iframe',
+            url: '//ap.lijit.com/beacon?informer=' + iidArr[0] + '&gdpr_consent=' + consentString,
+          });
+        }
+      }
+      if (errorpxls.length && syncOptions.pixelEnabled) {
+        tracks = tracks.concat(errorpxls)
       }
-      if (iidArr[0]) {
-        return [{
-          type: 'iframe',
-          url: '//ap.lijit.com/beacon?informer=' + iidArr[0] + '&gdpr_consent=' + consentString,
-        }];
+      return tracks
+    } catch (e) {
+      if (syncOptions.pixelEnabled) {
+        return errorpxls
       }
+      return []
     }
-    return [];
   },
-};
+}
+
+export class LogError {
+  constructor(e, data) {
+    utils.logError(e)
+    this.error = {}
+    this.error.t = utils.timestamp()
+    this.error.m = e.message
+    this.error.s = e.stack
+    this.error.d = data
+    this.error.v = REPO_AND_VERSION
+    this.error.u = utils.getTopWindowLocation().href
+    this.error.ua = navigator.userAgent
+  }
+  buildErrorString(obj) {
+    return errorUrl + '?b=' + btoa(JSON.stringify(obj))
+  }
+  append() {
+    let errstr = this.buildErrorString(this.error)
+    if (errstr.length > 2083) {
+      delete this.error.d
+      errstr = this.buildErrorString(this.error)
+      if (errstr.length > 2083) {
+        delete this.error.s
+        errstr = this.buildErrorString(this.error)
+        if (errstr.length > 2083) {
+          errstr = this.buildErrorString({m: 'unknown error message', t: this.error.t, u: this.error.u})
+        }
+      }
+    }
+    let obj = {type: 'image', url: errstr}
+    errorpxls.push(obj)
+  }
+  static getErrPxls() {
+    return errorpxls
+  }
+}
 
 registerBidder(spec);