Updated Sovrn Bid Adaptor for MultiSized and added Error Call Home. #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrosendahl
changed the title
mike-chowla
requested changes
Oct 30, 2018
|
I have addressed existing comments in the most recent commit. Mike if you are too busy to do this review, would it help if I split multi-sized support and error tracking into two PR's? |
|
This pull request introduces 1 alert when merging f165cb0 into 2c5685c - view on LGTM.com new alerts:
Comment posted by LGTM.com |
idettman
approved these changes
Nov 6, 2018
jrosendahl
changed the title
|
So, is there something I need to do to get this merged? Please let me know if there is anything I can do to help move this forward. |
|
@jrosendahl Can you rebase off of master? There were some updates made to the test directory and various test files that should address this error. |
mike-chowla
approved these changes
Nov 9, 2018
mike-chowla
requested changes
Nov 9, 2018
|
Coverage is now at 91% for module. |
mike-chowla
approved these changes
Nov 15, 2018
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…rebid#3237) * Updated Bid Adaptor for MultiSized and added Error Call Home * Updated to conform with prebid requirements * added missing this * Added tests for more coverage * simplified error object for edge 15
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
…rebid#3237) * Updated Bid Adaptor for MultiSized and added Error Call Home * Updated to conform with prebid requirements * added missing this * Added tests for more coverage * simplified error object for edge 15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updated Sovrn Adapter to support multisized ads and record errors
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information