Skip to content

Commit

Permalink
AdagioBidAdapter: cast organizationId param as a string (#4721)
Browse files Browse the repository at this point in the history
* AdagioBidAdapter: cast organizationId param as a string

* AdagioBidAdapter: Fix tests
  • Loading branch information
osazos authored and bretg committed Jan 14, 2020
1 parent ae820af commit 9eaf6e5
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
3 changes: 3 additions & 0 deletions modules/adagioBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,9 @@ export const spec = {

// Regroug ad units by siteId
const groupedAdUnits = adUnits.reduce((groupedAdUnits, adUnit) => {
if (adUnit.params && adUnit.params.organizationId) {
adUnit.params.organizationId = adUnit.params.organizationId.toString();
}
(groupedAdUnits[adUnit.params.organizationId] = groupedAdUnits[adUnit.params.organizationId] || []).push(adUnit);
return groupedAdUnits;
}, {});
Expand Down
11 changes: 10 additions & 1 deletion test/spec/modules/adagioBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,16 @@ describe('adagioAdapter', () => {
const requests = spec.buildRequests([bidRequests[0]], bidderRequest);
const request = requests[0];
expect(request.data.adUnits[0].features.print_number).to.equal('2');
})
});

it('organizationId param key must be a string', () => {
const requests = spec.buildRequests([Object.assign({}, bidRequests[0], {params: {organizationId: 1010}})], bidderRequest);
const request = requests[0];
expect(request.data.adUnits[0].params).to.exist;
expect(request.data.adUnits[0].params.organizationId).to.deep.equal('1010');
expect(request.data.organizationId).to.exist;
expect(request.data.organizationId).to.deep.equal('1010');
});

it('GDPR consent is applied', () => {
const requests = spec.buildRequests(bidRequests, bidderRequest);
Expand Down

0 comments on commit 9eaf6e5

Please sign in to comment.