Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdagioBidAdapter: cast organizationId param as a string #4721

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

osazos
Copy link
Collaborator

@osazos osazos commented Jan 13, 2020

Type of change

  • [ x] Bugfix

Description of change

Force the adagio organizationId param to be a string and avoid customers to get a bad response from Adagio SSP.

Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the Adagio doc does declare this a string

@bretg bretg merged commit 9eaf6e5 into prebid:master Jan 14, 2020
audiencerun pushed a commit to audiencerun/Prebid.js that referenced this pull request Jan 20, 2020
* AdagioBidAdapter: cast organizationId param as a string

* AdagioBidAdapter: Fix tests
osazos added a commit to onfocusio/Prebid.js that referenced this pull request Jan 23, 2020
* adagioBidAdapter: avoid preflight requests

* adagioBidAdapter: always return computable features

AdagioBidAdapter: cast organizationId param as a string (prebid#4721)

* AdagioBidAdapter: cast organizationId param as a string

* AdagioBidAdapter: Fix tests
mkendall07 pushed a commit that referenced this pull request Jan 28, 2020
* adagioBidAdapter: avoid preflight requests

* adagioBidAdapter: always return computable features

AdagioBidAdapter: cast organizationId param as a string (#4721)

* AdagioBidAdapter: cast organizationId param as a string

* AdagioBidAdapter: Fix tests
@osazos osazos deleted the adg_cast-organizationid-param branch February 28, 2020 08:33
hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
* AdagioBidAdapter: cast organizationId param as a string

* AdagioBidAdapter: Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants