Skip to content

Commit

Permalink
New adapter: Colombia (#5158)
Browse files Browse the repository at this point in the history
* Add colombia adapter

* Add https in the url

* update files

* add test cases and update md file

* remove native from package.json and update colombia test cases

* Use conditions for the size

* Use conditions for the size and remove test warnings

* remove package.json

* Resolved import related errors

* update referrer method

* remove package json and update referer path

* revert package json

* Resolved all changes

* update version package json

* Resolved test cases issues
  • Loading branch information
ColombiaOnline authored Apr 27, 2020
1 parent 0eeaccb commit a883653
Show file tree
Hide file tree
Showing 5 changed files with 242 additions and 4 deletions.
82 changes: 82 additions & 0 deletions modules/colombiaBidAdapter.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
import * as utils from '../src/utils.js';
import {config} from '../src/config.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import { BANNER } from '../src/mediaTypes.js';
const BIDDER_CODE = 'colombia';
const ENDPOINT_URL = 'https://ade.clmbtech.com/cde/prebid.htm';
const HOST_NAME = document.location.protocol + '//' + window.location.host;

export const spec = {
code: BIDDER_CODE,
aliases: ['clmb'],
supportedMediaTypes: [BANNER],
isBidRequestValid: function(bid) {
return !!(bid.params.placementId);
},
buildRequests: function(validBidRequests, bidderRequest) {
return validBidRequests.map(bidRequest => {
const params = bidRequest.params;
const sizes = utils.parseSizesInput(bidRequest.sizes)[0];
const width = sizes.split('x')[0];
const height = sizes.split('x')[1];
const placementId = params.placementId;
const cb = Math.floor(Math.random() * 99999999999);
const bidId = bidRequest.bidId;
const referrer = (bidderRequest && bidderRequest.refererInfo) ? bidderRequest.refererInfo.referer : '';
const payload = {
v: 'hb1',
p: placementId,
w: width,
h: height,
cb: cb,
r: referrer,
uid: bidId,
t: 'i',
d: HOST_NAME,
};
return {
method: 'POST',
url: ENDPOINT_URL,
data: payload,
}
});
},
interpretResponse: function(serverResponse, bidRequest) {
const bidResponses = [];
const response = serverResponse.body;
const crid = response.creativeId || 0;
const width = response.width || 0;
const height = response.height || 0;
let cpm = response.cpm || 0;
if (width == 300 && height == 250) {
cpm = cpm * 0.2;
}
if (width == 320 && height == 50) {
cpm = cpm * 0.55;
}
if (cpm < 1) {
return bidResponses;
}
if (width !== 0 && height !== 0 && cpm !== 0 && crid !== 0) {
const dealId = response.dealid || '';
const currency = response.currency || 'USD';
const netRevenue = (response.netRevenue === undefined) ? true : response.netRevenue;
const bidResponse = {
requestId: bidRequest.data.uid,
cpm: cpm,
width: response.width,
height: response.height,
creativeId: crid,
dealId: dealId,
currency: currency,
netRevenue: netRevenue,
ttl: config.getConfig('_bidderTimeout'),
referrer: bidRequest.data.r,
ad: response.ad
};
bidResponses.push(bidResponse);
}
return bidResponses;
}
}
registerBidder(spec);
8 changes: 6 additions & 2 deletions modules/colombiaBidAdapter.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,17 @@ Maintainer: colombiaonline@timesinteret.in

Connect to COLOMBIA for bids.

THE COLOMBIA adapter requires setup and approval from the COLOMBIA team. Please reach out to your account team or colombiaonline@timesinteret.in for more information.
COLOMBIA adapter requires setup and approval from the COLOMBIA team. Please reach out to your account team or colombiaonline@timesinteret.in for more information.

# Test Parameters
```
var adUnits = [{
code: 'test-ad-div',
sizes: [[300, 250]],
mediaTypes: {
banner: {
sizes: [[300, 250],[728,90],[320,50]]
}
},
bids: [{
bidder: 'colombia',
params: {
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
100755 → 100644
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "prebid.js",
"version": "3.18.0-pre",
"version": "3.12.0",
"description": "Header Bidding Management Library",
"main": "src/prebid.js",
"scripts": {
Expand Down
152 changes: 152 additions & 0 deletions test/spec/modules/colombiaBidAdapter_spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,152 @@
import { expect } from 'chai';
import { spec } from 'modules/colombiaBidAdapter';
import { newBidder } from 'src/adapters/bidderFactory';

const HOST_NAME = document.location.protocol + '//' + window.location.host;
const ENDPOINT = 'https://ade.clmbtech.com/cde/prebid.htm';

describe('colombiaBidAdapter', function() {
const adapter = newBidder(spec);

describe('isBidRequestValid', function () {
let bid = {
'bidder': 'colombia',
'params': {
placementId: '307466'
},
'adUnitCode': 'adunit-code',
'sizes': [
[300, 250]
],
'bidId': '23beaa6af6cdde',
'bidderRequestId': '19c0c1efdf37e7',
'auctionId': '61466567-d482-4a16-96f0-fe5f25ffbdf1',
};

it('should return true when required params found', function () {
expect(spec.isBidRequestValid(bid)).to.equal(true);
});

it('should return false when placementId not passed correctly', function () {
bid.params.placementId = '';
expect(spec.isBidRequestValid(bid)).to.equal(false);
});

it('should return false when require params are not passed', function () {
let bid = Object.assign({}, bid);
bid.params = {};
expect(spec.isBidRequestValid(bid)).to.equal(false);
});
});

describe('buildRequests', function () {
let bidRequests = [
{
'bidder': 'colombia',
'params': {
placementId: '307466'
},
'adUnitCode': 'adunit-code1',
'sizes': [
[300, 250]
],
'bidId': '23beaa6af6cdde',
'bidderRequestId': '19c0c1efdf37e7',
'auctionId': '61466567-d482-4a16-96f0-fe5f25ffbdf1',
},
{
'bidder': 'colombia',
'params': {
placementId: '307466'
},
'adUnitCode': 'adunit-code2',
'sizes': [
[300, 250]
],
'bidId': '382091349b149f"',
'bidderRequestId': '"1f9c98192de251"',
'auctionId': '61466567-d482-4a16-96f0-fe5f25ffbdf1',
}
];

const request = spec.buildRequests(bidRequests);

it('sends bid request to our endpoint via POST', function () {
expect(request[0].method).to.equal('POST');
expect(request[1].method).to.equal('POST');
});

it('attaches source and version to endpoint URL as query params', function () {
expect(request[0].url).to.equal(ENDPOINT);
expect(request[1].url).to.equal(ENDPOINT);
});
});

describe('interpretResponse', function () {
let bidRequest = [
{
'method': 'POST',
'url': 'https://ade.clmbtech.com/cde/prebid.htm',
'data': {
'v': 'hb1',
'p': '307466',
'w': '300',
'h': '250',
'cb': 12892917383,
'r': 'http%3A%2F%2Flocalhost%3A9876%2F%3Fid%3D74552836',
'uid': '23beaa6af6cdde',
't': 'i',
}
}
];

let serverResponse = {
body: {
'ad': '<div>This is test case for colombia adapter</div> ',
'cpm': 3.14,
'creativeId': '6b958110-612c-4b03-b6a9-7436c9f746dc-1sk24',
'currency': 'USD',
'uid': '23beaa6af6cdde',
'width': 728,
'height': 90,
'netRevenue': true,
'ttl': 600,
'dealid': '',
'referrer': 'http%3A%2F%2Flocalhost%3A9876%2F%3Fid%3D74552836'
}
};

it('should get the correct bid response', function () {
let expectedResponse = [{
'requestId': '23beaa6af6cdde',
'cpm': 3.14,
'width': 728,
'height': 90,
'creativeId': '6b958110-612c-4b03-b6a9-7436c9f746dc-1sk24',
'dealId': '',
'currency': 'USD',
'netRevenue': true,
'ttl': 300,
'referrer': 'http%3A%2F%2Flocalhost%3A9876%2F%3Fid%3D74552836',
'ad': '<div>This is test case for colombia adapter</div>'
}];
let result = spec.interpretResponse(serverResponse, bidRequest[0]);
expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse[0]));
});

it('handles empty bid response', function () {
let response = {
body: {
'uid': '23beaa6af6cdde',
'height': 0,
'creativeId': '',
'statusMessage': 'Bid returned empty or error response',
'width': 0,
'cpm': 0
}
};
let result = spec.interpretResponse(response, bidRequest[0]);
expect(result.length).to.equal(0);
});
});
});

0 comments on commit a883653

Please sign in to comment.