New adapter: Colombia #5158
New adapter: Colombia #5158
Conversation
|
@musikele |
| 'ad': '<div>This is test case for colombia adapter</div>' | ||
| }]; | ||
| let result = spec.interpretResponse(serverResponse, bidRequest[0]); | ||
| expect(Object.keys(result)).to.deep.equal(Object.keys(expectedResponse)); |
There was a problem hiding this comment.
When Running npx gulp test, I get this error:
✖ should get the correct bid response
HeadlessChrome 81.0.4044 (Mac OS X 10.15.4)
TypeError: Cannot convert undefined or null to object
at keys (<anonymous>)
at Function.keys (node_modules/es5-shim/es5-shim.js:1145:24)
at Context.<anonymous> (webpack:///test/spec/modules/colombiaBidAdapter_spec.js:134:21 <- test/test_index.js:113581:67)
| } | ||
| }; | ||
| let result = spec.interpretResponse(response, bidRequest[0]); | ||
| expect(result.length).to.equal(0); |
There was a problem hiding this comment.
When running npx gulp test, I get this other error:
✖ handles empty bid response
HeadlessChrome 81.0.4044 (Mac OS X 10.15.4)
TypeError: Cannot read property 'length' of undefined
at Context.<anonymous> (webpack:///test/spec/modules/colombiaBidAdapter_spec.js:149:21 <- test/test_index.js:113595:67)
There was a problem hiding this comment.
Hi @ColombiaOnline,
- Two tests are still failing on the running the command.
gulp test(Also the CI is failing because of that). Please find the screenshot for your reference:
- In the
colombiaBidAdapter.mdfile, you need to change your example ad unit. With the release ofPrebid v3.0we've removed the propertysizesto declare ad unit sizes. Instead, use themediaTypes property. For example, if you are serving Banner ads, it should look like,
[{
code: 'test-ad-div',
mediaTypes: {
banner: {
sizes: [[300, 250]]
}
},
bids: [{
bidder: 'colombia',
params: {
placementId: '307466'
}
}]
}];
-
In
colombiaBidAdapter.jsfile, you are missing this property, supportedMediaTypes, which is an array of media types your bidder supports. Please refer to theappnexusBidAdapter.jsfor reference. -
Is there any particular reason to modify cpm value. I three instances in which I see modifications made to the cpm value.
Prebid.js/modules/colombiaBidAdapter.js
Line 50 in c22f94c
Prebid.js/modules/colombiaBidAdapter.js
Line 53 in c22f94c
Prebid.js/modules/colombiaBidAdapter.js
Line 56 in c22f94c
-
Docs PR is missing. Please create a PR against this repo, https://github.com/prebid/prebid.github.io. Follow instructions given at this page! http://prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter
-
Your test-coverage is 44%. We require minimum 80% test coverage.
|
Hi @Fawke , Please reviews changes and push the files in prebid repository asap . |
* Add colombia adapter * Add https in the url * update files * add test cases and update md file * remove native from package.json and update colombia test cases * Use conditions for the size * Use conditions for the size and remove test warnings * remove package.json * Resolved import related errors * update referrer method * remove package json and update referer path * revert package json * Resolved all changes * update version package json * Resolved test cases issues
Type of change
Description of change
We have uses some conditions for banner sizes.