Skip to content

Commit

Permalink
added missing dfpAdServerVideo.js dfp vast tag generation uri compone… (
Browse files Browse the repository at this point in the history
#2440)

* added missing dfpAdServerVideo.js dfp vast tag generation uri component encoding

* fixed buildDfpVideoUrl not returning empty targeting

* reverted last commits change because it broke display targeting
  • Loading branch information
Slind14 authored and mkendall07 committed Apr 30, 2018
1 parent 1ed012a commit b1f043d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions modules/dfpAdServerVideo.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export default function buildDfpVideoUrl(options) {
const derivedParams = {
correlator: Date.now(),
sz: parseSizesInput(adUnit.sizes).join('|'),
url: location.href,
url: encodeURIComponent(location.href),
};
const encodedCustomParams = getCustParams(bid, options);

Expand Down Expand Up @@ -152,7 +152,7 @@ function getCustParams(bid, options) {
adserverTargeting,
{ hb_uuid: bid && bid.videoCacheKey },
// hb_uuid will be deprecated and replaced by hb_cache_id
{hb_cache_id: bid && bid.videoCacheKey},
{ hb_cache_id: bid && bid.videoCacheKey },
optCustParams,
);
return encodeURIComponent(formatQS(customParams));
Expand Down
2 changes: 1 addition & 1 deletion src/targeting.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const isBidExpired = (bid) => (bid.responseTimestamp + bid.ttl * 1000 + T
const isUnusedBid = (bid) => bid && ((bid.status && !includes([BID_TARGETING_SET, RENDERED], bid.status)) || !bid.status);

// If two bids are found for same adUnitCode, we will use the latest one to take part in auction
// This can happen in case of concurrent autions
// This can happen in case of concurrent auctions
export const getOldestBid = function(bid, i, arr) {
let oldestBid = true;
arr.forEach((val, j) => {
Expand Down

0 comments on commit b1f043d

Please sign in to comment.