added missing dfpAdServerVideo.js dfp vast tag generation uri compone… #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, is no one using this prebid feature or was it changed recently? |
|
There was another issue with BuildDfpVideoUrl returning the URL without targeting (race condition with setTargetingForGPTAsync). I fixed it removing this filter. I'm not sure if this is the right place. Edit: reverted, since it broke display |
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
prebid#2440) * added missing dfpAdServerVideo.js dfp vast tag generation uri component encoding * fixed buildDfpVideoUrl not returning empty targeting * reverted last commits change because it broke display targeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DFP urls built from sites containing special chars and or get params them self were invalid and causing dfp internal server errors.