Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing dfpAdServerVideo.js dfp vast tag generation uri compone… #2440

Merged
merged 3 commits into from
Apr 30, 2018
Merged

added missing dfpAdServerVideo.js dfp vast tag generation uri compone… #2440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7b9dfe
added missing dfpAdServerVideo.js dfp vast tag generation uri compone…
Slind14 Apr 21, 2018
ac84a87
fixed buildDfpVideoUrl not returning empty targeting
Slind14 Apr 22, 2018
4b6877b
reverted last commits change because it broke display targeting
Slind14 Apr 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/dfpAdServerVideo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export default function buildDfpVideoUrl(options) {
const derivedParams = {
correlator: Date.now(),
sz: parseSizesInput(adUnit.sizes).join('|'),
url: location.href,
url: encodeURIComponent(location.href),
};
const encodedCustomParams = getCustParams(bid, options);

Expand Down Expand Up @@ -152,7 +152,7 @@ function getCustParams(bid, options) {
adserverTargeting,
{ hb_uuid: bid && bid.videoCacheKey },
// hb_uuid will be deprecated and replaced by hb_cache_id
{hb_cache_id: bid && bid.videoCacheKey},
{ hb_cache_id: bid && bid.videoCacheKey },
optCustParams,
);
return encodeURIComponent(formatQS(customParams));
Expand Down
2 changes: 1 addition & 1 deletion src/targeting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const isBidExpired = (bid) => (bid.responseTimestamp + bid.ttl * 1000 + T
const isUnusedBid = (bid) => bid && ((bid.status && !includes([BID_TARGETING_SET, RENDERED], bid.status)) || !bid.status);

// If two bids are found for same adUnitCode, we will use the latest one to take part in auction
// This can happen in case of concurrent autions
// This can happen in case of concurrent auctions
export const getOldestBid = function(bid, i, arr) {
let oldestBid = true;
arr.forEach((val, j) => {
Expand Down