Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size mapping not working for outstream adunit #2276

Closed
sajokj opened this issue Mar 16, 2018 · 6 comments
Closed

Size mapping not working for outstream adunit #2276

sajokj opened this issue Mar 16, 2018 · 6 comments

Comments

@sajokj
Copy link

sajokj commented Mar 16, 2018

Type of issue

Bug

Description

If we have 4 adunits on a page, in which 3 adunits are just banners and 1 with outstream, the Size mapping /sizeConfig will not work for outstream. When requesting for bid the outstream adunit is always ignored. If I remove the sizeConfig and labels it works fine.

Steps to reproduce

Have a page with 2 adunits one with banner another with Outstream and enable Size mapping /sizeConfig

Expected results

Both Outstream and Banners should work with Size mapping /sizeConfig

Platform details

Prebid.js 1.4.0

Other information

@bretg
Copy link
Collaborator

bretg commented Mar 19, 2018

Please post an example sizeConfig and AdUnits that illustrate the problem

@sajokj
Copy link
Author

sajokj commented Mar 19, 2018

Here is the code:
https://jsfiddle.net/8L2n2v3j/2/

@jsnellbaker
Copy link
Collaborator

Hi @sajokj I have put together a fix for this bug. Once it's reviewed and merged, it should be included in the next corresponding 1.x release.

As part of the fix, you'll need to update your adUnit config so that mediaTypes.video.playerSize is using a syntax like [[640, 480]] instead of the previous [640, 480]. This syntax update should allow the video adUnit to work with the Size Mapping functionality properly. Please let me know if there are any questions.

@sajokj
Copy link
Author

sajokj commented Mar 26, 2018

Thank you @jsnellbaker for the Fix

@sajokj
Copy link
Author

sajokj commented Mar 27, 2018

@jsnellbaker is this live on production on the Prebid ver 1.6.0

I cant find the same on change log.

@jsnellbaker
Copy link
Collaborator

@sajokj This fix is still within a Pull Request (ie review) status and has not been implemented. Once it's reviewed/merged into the master branch, it will available with the next prebid release.

dluxemburg pushed a commit to Genius/Prebid.js that referenced this issue Jul 17, 2018
…ether (prebid#2311)

* initial commit - fix to make playerSize and sizeConfig work

* removed commented from testing

* adding support to use [300, 600] syntax in video.playerSize field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants