-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Size mapping not working for outstream adunit #2276
Comments
Please post an example sizeConfig and AdUnits that illustrate the problem |
Here is the code: |
Hi @sajokj I have put together a fix for this bug. Once it's reviewed and merged, it should be included in the next corresponding 1.x release. As part of the fix, you'll need to update your adUnit config so that |
Thank you @jsnellbaker for the Fix |
@jsnellbaker is this live on production on the Prebid ver 1.6.0 I cant find the same on change log. |
@sajokj This fix is still within a Pull Request (ie review) status and has not been implemented. Once it's reviewed/merged into the master branch, it will available with the next prebid release. |
…ether (prebid#2311) * initial commit - fix to make playerSize and sizeConfig work * removed commented from testing * adding support to use [300, 600] syntax in video.playerSize field
Type of issue
Bug
Description
If we have 4 adunits on a page, in which 3 adunits are just banners and 1 with outstream, the Size mapping /sizeConfig will not work for outstream. When requesting for bid the outstream adunit is always ignored. If I remove the sizeConfig and labels it works fine.
Steps to reproduce
Have a page with 2 adunits one with banner another with Outstream and enable Size mapping /sizeConfig
Expected results
Both Outstream and Banners should work with Size mapping /sizeConfig
Platform details
Prebid.js 1.4.0
Other information
The text was updated successfully, but these errors were encountered: