Fixes #2276 - video.playerSize and Size Mapping not working together

[jsnellbaker]

Type of change

• Bugfix

Description of change

Currently, using Size Mapping functionality with a video adUnit that specifies mediaTypes.video.playerSize would not pass the sizeMapping.js validation checks causing the ad unit to not be included in the bidRequest object.

As a quick recap, the validation check in the sizeMapping (located here https://github.com/prebid/Prebid.js/blob/master/src/sizeMapping.js#L41) does the following:

• uses a list of arrayed sizes (ie [[300, 250], [300, 600]]) as a list of acceptable sizes (this is derived from the matching mediaQuery params).
• It reads the adUnit's size params and cross checks that array against the mediaQuery list of sizes
• if it finds a match, the size passes the filter
• otherwise if no sizes are matched, the bid doesn't get added to the request

Because the filtering operates on a list of arrayed sizes, the adUnits.sizes has to use the same format. Otherwise, the filter would treat the single array of sizes ie [300, 250] as two integers and the size wouldn't pass the check.

To meet this requirement, I changed the adUnits.mediaTypes.video.playerSize field to accept either format (ie [[640, 480]] or [640, 480]) but it will automatically format the latter syntax into the former.

A note - while the playerSize field will expect an array of an array, there should only 1 set of sizes in the field. The changes in the checkBidRequestSizes() function check for this exact type of setup.

Other information

fixes issue reported in #2276

[matthewlane]

Can drop this line if no longer needed

[jsnellbaker]

Removed it.

[jsnellbaker]

@matthewlane Per your separate feedback, I added support for the mediaTypes.video.playerSize field to be able to take either [[640, 480]] or [640,480] syntax styles. When the code detects the latter style, it automatically converts it to the former style to ensure it works with sizeMapping functionality.

I'll update the original description in lieu of the functionality change.