Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit tests to not use Arrow functions as recommended by Mocha #2987

Closed
jaiminpanchal27 opened this issue Aug 16, 2018 · 2 comments
Closed

Update unit tests to not use Arrow functions as recommended by Mocha #2987

jaiminpanchal27 opened this issue Aug 16, 2018 · 2 comments
Labels
assigned bug good first issue

Comments

@jaiminpanchal27
Copy link
Collaborator

Type of issue

Bug

Description

Passing arrow functions (“lambdas”) to Mocha is discouraged.
https://mochajs.org/#arrow-functions

mochajs/mocha#2018
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions
@thewizarodofoz
Copy link
Contributor

I would be happy to take this.

@mkendall07
Copy link
Member

awesome, thanks!

@thewizarodofoz thewizarodofoz mentioned this issue Aug 30, 2018
Merged
9 tasks
This was referenced Sep 17, 2018
Merged
Merged
@jaiminpanchal27 jaiminpanchal27 mentioned this issue Dec 3, 2018
Merged
10 tasks
@jsnellbaker jsnellbaker mentioned this issue Dec 7, 2018
Merged
1 task
@jaiminpanchal27 jaiminpanchal27 mentioned this issue Mar 15, 2019
Merged
2 tasks
piotr-yuxuan added a commit to Adikteev/Prebid.js that referenced this issue Mar 15, 2019
@piotr-yuxuan
Not arrow functions in spec
e54a494 
prebid#2987
piotr-yuxuan added a commit to Adikteev/Prebid.js that referenced this issue Mar 15, 2019
@piotr-yuxuan
No arrow functions in spec
542b03f 
prebid#2987
piotr-yuxuan added a commit to Adikteev/Prebid.js that referenced this issue Mar 23, 2019
@piotr-yuxuan
No arrow functions in spec
a71c023 
prebid#2987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkendall07 @jaiminpanchal27 @thewizarodofoz