Add Colombia adapter

[ColombiaOnline]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Add Colombia adapter for Prebid .
Some test parameters for the bidder:

var adUnits = [{
    code: 'test-ad-div',
    sizes: [[300, 250]],
    bids: [{
    bidder: 'colombia',
      params: { 
        placementId: '44082'
       }
     }]
  }];

Our general contact email address is colombiaonline@timesinteret.in, and for anything related to this bidder, feel free to reach out to me at colombiaonline@timesinteret.in.

Other information

[jsnellbaker]

@ColombiaOnline When you get the chance please perform the following:

• rebase off of master (this should fix the circleci errrors)
• add unit tests for your adapter (please refer to this page for some additional details and a link to see how other adapters setup their unit tests).
• create a PR in the docs repo and add your bidder info under here. Feel free to look at how other adapters setup their files if you need a reference (eg appnexus or rubicon).

[idettman]

CircleCI tests are failing, I re-ran but tests failed again.

[idettman]

code LGTM

[ColombiaOnline]

@idettman
We have fixed the circleci & LGTM errors. please continue to next process for merge.

[bretg]

docs PR at prebid/prebid.github.io#937

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ColombiaOnline]

we are working on conflict and unit test cases.

[ColombiaOnline]

We have successfully resolved the conflict.

[jsnellbaker]

Hi @ColombiaOnline

There are still some items to address in this PR before it can be merged.

Please see below:

• when I tested the bid params from the .md file in the hello_world.html page, I saw the following response instead of an actual banner ad:

{"cpm":0.0,"width":0,"height":0,"currency":"USD","netRevenue":true,"ttl":0}

Could you look into returning an actual test ad consistently?

• Additionally the page loaded with a CORS error (see attachment for details of the message).

• The unit tests for your adapter file are still missing. Can you please put this file together and add it into the PR?

• See the point in the package.json file; additionally, please try to undo the change that was made in the package-lock.json file.

Please let me know if you have any questions.

[jsnellbaker]

Why was this natives package added in? It should be removed if there's no need for it.

[jsnellbaker]

See screenshot for CORS related error mentioned above:

[ColombiaOnline]

@jsnellbaker we have updated the code covering all the points pointed by you. Please review.

[jsnellbaker]

Hi @ColombiaOnline

Thanks for making the various updates. I tested the adapter again and found it working successfully now (no CORS errors).

However, I noticed the natives package is still present in the package.json file. If this is intentional, can you please elaborate on this change? If not, please remove the extra package from the file and we should be good to merge.

Thanks.

[jsnellbaker]

@ColombiaOnline Actually, I forgot to mention something in the previous update. In regards to the spec.js you added - in the various unit test functions, can you please convert the ,() => { arrow syntax to the standard , function() { syntax?

This styling change was recently implemented across the project in an effort to better comply with Mocha standards. So we'd like new adapters to conform with the change. Please see #2987 for reference on the change.

[ColombiaOnline]

@jsnellbaker we have updated the code covering all the points pointed by you. Please review

[jsnellbaker]

@ColombiaOnline Thanks for the additional changes; LGTM.