Auction ends prematurely [1.24.0]

[dugwood]

Type of issue

Bug

Description

After updating from 1.23.0 to 1.24.0 a drop in revenues occurred.

Steps to reproduce

Upgrade to 1.24.0 and look for the auction's end. If you have some debug, you'll see that auction ends before some valid bids.
Note that reading the releases' page didn't show any new parameter involved.

Test page

No test page as I've reverted back to 1.23.0 in production.

Expected results

All bids should arrive before auction ends.

Actual results

Auction ends in the middle of bids. Most probably Criteo (the fastest bid response) cut all other (but Criteo is also cut by other bidders sometimes).

Platform details

Compiled on Linux Debian, Node 8.11.4, npm 5.6.0

Other information

Change to 1.23.0 at 11:45, reverted at 17:00.

Sent bids (for AppNexus) vs returned bids (darker green):

Revenues (still only AppNexus):

Sent bids for Criteo, less impacted as it's the fastest:

[jaiminpanchal27]

@dugwood Can you share the url of the page ?

[dugwood]

@jaiminpanchal27 I've reverted back... I'll try to setup one, I'll let you know.

[dugwood]

@jaiminpanchal27 for a limited period of time:
https://www.lacoccinelle.net/prebid.html?20190916#debug-ads-for-skyboard-670168053

You should see some debugs, hide the «Zone 17980» and just focus on «Zone 438».

For example I can see:

=> here AppNexus answers within the 2000ms timeout, but rubicon wins. The «Winner» is a message sent in the bidsBackHandler... so the auction is already ended.

[dugwood]

Numbers in gray are the time in milliseconds.

To enable Prebid debug, use the following url:
https://www.lacoccinelle.net/prebid.html?20190916#debug-ads-for-skyboard-670168053&pbjs_debug=true
(as GET parameters are forbidden)

[jaiminpanchal27]

@dugwood Thanks. Checking now

[jaiminpanchal27]

@dugwood Found the bug. We will do the patch release tomorrow. Thanks for contribution.

[jaiminpanchal27]

@dugwood Can you test with #3096 branch.

[dugwood]

Thanks @jaiminpanchal27, it seems to work much better:
https://www.lacoccinelle.net/prebid.html?20190916#debug-ads-for-skyboard-670168053&pbjs_debug=true