Fixes #3091 Auction closing prematurely #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
approved these changes
Sep 14, 2018
test/spec/auctionmanager_spec.js
Outdated
| assert.equal(doneSpy.callCount, 1); | ||
| }); | ||
|
|
||
| it('should call auction done after prebid cache is complete for mediaType video', function() { | ||
| debugger; // eslint-disable-line |
src/auction.js
Outdated
| let doneCalled = false; | ||
| let allAdapterCalledDone = false; | ||
|
|
||
| let areAllAdapterDone = delayExecution(() => { |
There was a problem hiding this comment.
nice usage here. One knit (I know it's not part of this PR) but the name of this function is somewhat confusing. I was expecting it to wait for the next turn of the event loop, but it's synchronous.
src/auction.js
Outdated
| doneCalled = true; | ||
| if ((outstandingBidsAdded === 0)) { | ||
| areAllAdapterDone(); | ||
| if (allAdapterCalledDone && (outstandingBidsAdded === 0)) { |
There was a problem hiding this comment.
double parentheses are not needed here.
janua
pushed a commit
to guardian/Prebid.js
that referenced
this pull request
Sep 24, 2018
* auction closing early fix * minor updates after code review
ptomasroos
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Sep 25, 2018
* auction closing early fix * minor updates after code review
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* auction closing early fix * minor updates after code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes #3091 Auction closing prematurely