Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in yieldmo adapter when synchronously executing code in html head #4107

Closed
mhlm opened this issue Aug 21, 2019 · 3 comments
Closed

Error in yieldmo adapter when synchronously executing code in html head #4107

mhlm opened this issue Aug 21, 2019 · 3 comments

Comments

@mhlm
Copy link
Contributor

mhlm commented Aug 21, 2019

When synchronously executing the code in html head, the DOM is not yet formed, therefore window.document.body will be null. Because of this, an error first appears in this line (

window.document.body.appendChild(sacrificialIframe);

), and then in this (
window.document.body.removeChild(sacrificialIframe);
).

@jaiminpanchal27
Copy link
Collaborator

@elberdev

@elberdev
Copy link
Contributor

@jaiminpanchal27 We're looking to revise this to create a safer fallback

@stale
Copy link

stale bot commented Sep 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 13, 2019
@stale stale bot closed this as completed Sep 20, 2019
arconamagi pushed a commit to yieldmo/Prebid.js that referenced this issue Jul 20, 2020
bmwcmw pushed a commit that referenced this issue Aug 10, 2020
…imize #5098, minor refactoring (#5544)

Co-authored-by: Dmitriy Labuzov <dlabuzov@yieldmo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants