YieldMo optimization opportunity.

[DecayConstant]

I was investigating a Chrome performance profile, looking for bottlenecks in my own code, but I noticed this in a Prebid callBids call. YieldMo's own buildRequests is much slower than any other bid adapter. It's caused by the DOM manipulations that occur in the isSuperSandboxedIframe() function.

I don't know what that's for and if it's really necessary, but could you reorder the checks that happen in getEnvironment() so that the most common results are checked for first so you avoid the additional unnecessary checks for the less common environments? Or is the order of those checks important?

Prebid.js/modules/yieldmoBidAdapter.js

Lines 222 to 244 in 9eec929

	function getEnvironment() {
	if (isSuperSandboxedIframe()) {
	return 89;
	} else if (isDfpInAmp()) {
	return 5;
	} else if (isDfp()) {
	return 4;
	} else if (isAmp()) {
	return 1;
	} else if (isDFPSafeFrame()) {
	return 11;
	} else if (isSafeFrame()) {
	return 10;
	} else if (isMraid()) {
	return 2;
	} else if (isCodeOnPage()) {
	return 0;
	} else if (isSandboxedIframe()) {
	return 16;
	} else {
	return 90;
	}
	}

[snapwich]

@HolzAndrew ^

[mglowackiym]

Thank you for surfacing this. We will review internally and evaluate possible solutions.

[HolzAndrew]

@snapwich @DecayConstant I have alerted my team to this and we are adding it to our roadmap to address. Thank you!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.