Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Params in PubMatic #998

Closed
mohsink4u opened this issue Feb 17, 2017 · 2 comments
Closed

Additional Params in PubMatic #998

mohsink4u opened this issue Feb 17, 2017 · 2 comments

Comments

@mohsink4u
Copy link

Type of issue

Allowing Publishers to send key value pairs into PubMatic

Description

We would like to explore additional params from PubMatic. We want to pass categories into PubMatic which can then be used for targetting inside PubMatic. PubMatic has a param to achieve this:
var kaddctr="key1=val1,val2val3|key2=val12";

Steps to reproduce

Structure of PubMatic tag is like this:
`<script type="text/javascript">
// Specify multiple slot names over here
var pm_optimize_adslots = ['site2_section2@300x250','site3_section3@300x250'];
// PubMatic platform specific publisher identifier
var pm_pub_id = 7777;
// pm_custom is an optional parameter. Pass the key-values applicable for the impression in it to
the ad server. anything inside "" will need to be encoded. key1 has multiple params separated by commas(OR) and pipes(AND)
var kaddctr="key1=val1,val,val3|key2=val12";
var pm_async_callback_fn= 'pm_async_callback'; // Optional callback function name
</script>

<script type="text/javascript" src="http://ads.pubmatic.com/AdServer/js/gshowad.js"> </script>

`

Expected results

PubMatic will need to see this param:
dctr:key1=val,val2,val3|key2=val12
//kaddctr converts into dctr

Actual results

Tag needs to fire like this:
`<script type="text/javascript">
var pm_optimize_adslots = ['site2_section2@300x250','site3_section3@300x250'];
var pm_pub_id = 77777;
var kaddctr="key1%3Dval%2Cval2%2Cval3%7Ckey2%3Dval12";
// key values"key1=val,val2,val3|key2=val12" will need to be encoded before they are sent to PubMatic
//var pm_async_callback_fn= 'pm_async_callback'; // Optional callback function name
</script>

<script type="text/javascript" src="http://ads.pubmatic.com/AdServer/js/gshowad.js"> </script>`

Platform details

Other information

@boolean4
Copy link

boolean4 commented Feb 20, 2017

@mkendall07 @prebid

@mkendall07
Copy link
Member

We accpet PRs. Otherwise will add to the backlog to do at some point.

ptomasroos added a commit to happypancake/Prebid.js that referenced this issue May 19, 2017
protonate pushed a commit that referenced this issue Jun 7, 2017
…1213)

* Fixes #998 Allow keyvalues, gender and age to be passed in PubMatic's adapter

* Linting and make sure to define variables
jbAdyoulike pushed a commit to jbAdyoulike/Prebid.js that referenced this issue Sep 21, 2017
…atic (prebid#1213)

* Fixes prebid#998 Allow keyvalues, gender and age to be passed in PubMatic's adapter

* Linting and make sure to define variables
dluxemburg pushed a commit to Genius/Prebid.js that referenced this issue Jul 17, 2018
…atic (prebid#1213)

* Fixes prebid#998 Allow keyvalues, gender and age to be passed in PubMatic's adapter

* Linting and make sure to define variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants