Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #998 Allow keyvalues, gender and age to be passed in PubMatic #1213

Merged
merged 2 commits into from
Jun 5, 2017
Merged

Fixes #998 Allow keyvalues, gender and age to be passed in PubMatic #1213

merged 2 commits into from
Jun 5, 2017

Conversation

ptomasroos
Copy link
Contributor

@ptomasroos ptomasroos commented May 19, 2017 •
edited
Loading

Type of change

Feature

Description of change

This allows the bidder params to take gender, age and key values (in PubMatics required format)

Before

bidder: 'pubmatic',
  params: {
    publisherId: 'TO ADD',
    adSlot: 'TO ADD@300x250'
  }

Now

bidder: 'pubmatic',
  params: {
    publisherId: 'TO ADD',
    adSlot: 'TO ADD@300x250',
    age: '42', // optional
    gender: 'male', // optional
    kvs: 'key1=V1,V2,V3|key2=v1|key3=v3,v5' // optional
}

Key values format are documented here: https://developer.pubmatic.com/documentation/http-parameters-details See dctr

Issue #998

@protonate protonate self-requested a review May 24, 2017 19:17
@protonate protonate self-assigned this May 24, 2017
protonate
protonate approved these changes Jun 2, 2017
View reviewed changes
Copy link
Collaborator

@protonate protonate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

@protonate protonate added the LGTM label Jun 2, 2017
@protonate protonate added this to the Prebid 0.25.0 milestone Jun 2, 2017
@dbemiller dbemiller merged commit cf76e85 into prebid:master Jun 5, 2017
protonate pushed a commit that referenced this pull request Jun 7, 2017
@ptomasroos
Fixes #998 Allow keyvalues, gender and age to be passed in PubMatic (#…
36db4c0 
…1213)

* Fixes #998 Allow keyvalues, gender and age to be passed in PubMatic's adapter

* Linting and make sure to define variables
jbAdyoulike pushed a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017
@ptomasroos @jbAdyoulike
Fixes prebid#998 Allow keyvalues, gender and age to be passed in PubM…
d81834c 
…atic (prebid#1213)

* Fixes prebid#998 Allow keyvalues, gender and age to be passed in PubMatic's adapter

* Linting and make sure to define variables
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@ptomasroos @dluxemburg
Fixes prebid#998 Allow keyvalues, gender and age to be passed in PubM…
75ba5f2 
…atic (prebid#1213)

* Fixes prebid#998 Allow keyvalues, gender and age to be passed in PubMatic's adapter

* Linting and make sure to define variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protonate protonate protonate approved these changes

Assignees

@protonate protonate

Labels
LGTM
Projects
None yet
Milestone
Prebid 0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ptomasroos @protonate @dbemiller