Criteo Bid Adapter : remove usage of bidRequest.auctionId #10084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardlabat
force-pushed
the
criteoBidAdapter_auctionid
branch
from
03071e0 to
e32c292
Compare
patmmccann
reviewed
Jun 9, 2023
modules/criteoBidAdapter.js
Outdated
| @@ -427,6 +427,7 @@ function buildCdbRequest(context, bidRequests, bidderRequest) { | |||
| let schain; | |||
| let userIdAsEids; | |||
| const request = { | |||
| id: bidderRequest.ortb2?.source?.tid || generateUUID(), | |||
There was a problem hiding this comment.
this looks a bit like openrtb, $.id should be unique to the request and can be generateUUID() or bidderRequestId
patmmccann
reviewed
Jun 9, 2023
modules/criteoBidAdapter.js
Outdated
| @@ -445,7 +446,7 @@ function buildCdbRequest(context, bidRequests, bidderRequest) { | |||
| const slot = { | |||
| impid: bidRequest.adUnitCode, | |||
| transactionid: bidRequest.transactionId, | |||
| auctionId: bidRequest.auctionId, | |||
| auctionId: bidderRequest.ortb2?.source?.tid || generateUUID(), | |||
There was a problem hiding this comment.
Please make sure you're not passing this to dsps if you pass openrtb. This wouldn't comply with openrtb
There was a problem hiding this comment.
It won't be but indeed ; I've amended my change to make it completely obvious & transparent and rely exclusively on a random uuid
leonardlabat
force-pushed
the
criteoBidAdapter_auctionid
branch
from
e32c292 to
d81b63c
Compare
patmmccann
approved these changes
Jun 9, 2023
leonardlabat
force-pushed
the
criteoBidAdapter_auctionid
branch
from
d81b63c to
9af73d7
Compare
patmmccann
approved these changes
Jun 9, 2023
patmmccann
added a commit
that referenced
this pull request
Jun 14, 2023
* Prebid 8: Delete Inskin (#9868) * Delete inskinBidAdapter.js * Delete inskinBidAdapter.md * Delete inskinBidAdapter_spec.js * Prebid 8: Renaming TrustPid User ID module to Utiq (#9872) * feature: Add trustpid user id module * refactor: Update trustpidSystem module, comments and md file * refactor: Update trustpidSystem file to handle domain setting regardless of message events * refactor: Update trustpidSystem module and dependent tests and docs * refactor: Update trustpid undefined checks and returns * tests: Update trustpid tests * docs: Update trustpid docs typo * refactor: Update trustpid acronyms logic * TrustPid: Remove deprecated acronyms logic * Rename TrustPid User ID module to Utiq --------- Co-authored-by: Tomasz Januszek <tomasz@teavaro.com> * RTB-2173: Removing Inmar from Prebid (#8913) * Delete viewability.js (#9873) * Prebid 8: Delete realvu (#9867) * Delete realvuAnalyticsAdapter_spec.js * Delete realvuAnalyticsAdapter.md * Delete realvuAnalyticsAdapter.js * Prebid 8: Delete pubcid (#9869) * Realvu analytics adapter: fix test failures on Edge (#9857) * Realvu analytics adapter: fix test failures on Edge * Remove realVu tests * Delete pubCommonId.js * Delete pubCommonId.md * Delete pubCommonId_spec.js --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> * Prebid 8: Delete openxortb and analytics (#9864) * Delete openxOrtbBidAdapter.js * Delete openxOrtbBidAdapter.md * Delete openxOrtbBidAdapter_spec.js * Update openxBidAdapter_spec.js * Delete openxAnalyticsAdapter.js * Delete openxAnalyticsAdapter.md * Delete openxAnalyticsAdapter_spec.js * Core & multiple modules: populate ortb2.source.tid (#9862) * Core & multiple modules: populate ortb2.source.tid * enable codeql for prebid-8 * Prebid 8: IMDS bid adapter - Rename synacormedia adapter (#9381) * CAPT-252: Synacormedia bid adapter: add tmax to requests based upon provided timeouts. * Re-brand synacormedia adapter to imds (iMedia Digitial Services) * Add alias to synacormedia for backwards compatibility --------- Co-authored-by: Timothy M. Ace <tace@imds.tv> Co-authored-by: Pratik Chavan <pchavan@imds.tv> * Prebid 8: Dead Module removal (#9887) * Delete liveyieldAnalyticsAdapter_spec.js * Delete liveyieldAnalyticsAdapter.md * Delete liveyieldAnalyticsAdapter.js * Delete glimpseBidAdapter.js * Delete glimpseBidAdapter.md * Delete glimpseBidAdapter_spec.js * Prebid 8: Delete GA analytics - universal analytics (#9866) * Delete googleAnalyticsAdapter.js * Delete googleAnalyticsAdapter.md * Delete googleAnalyticsAdapter_spec.js * Prebid 8: Delete zeus (#9874) * Delete zeusPrimeRtdProvider.md * Delete zeusPrimeRtdProvider.js * Prebid 8: remove special augmentation of `auctionInit` event (#9897) * Prebid 8 - deprecate bidder category translation feature in core (#9898) * prebid 8 - deprecate category translation in core * remove storage export and move mapping data to library file * Prebid 8: Delete adgeneration (#9904) * Delete adgenerationBidAdapter_spec.js * Delete adgenerationBidAdapter.md * Delete adgenerationBidAdapter.js * Prebid 8: do not use hardcoded `bidderCode` in resposes from bid adapters (#9905) * Revert "Prebid 8: Delete adgeneration (#9904)" (#9915) This reverts commit ce984b3. * Prebid 8: No mas mass (#9909) * Delete index.html * Delete mass_spec.js * Delete mass.md * Delete mass.js * Prebid 8: Delete emx (#9918) * Delete emx_digitalBidAdapter.js * Delete emx_digitalBidAdapter.md * Delete emx_digitalBidAdapter_spec.js * Remove Rubicon Analytics for Prebid 8 (#9932) * Prebid 8: stop using transactionId as source.tid on ortb2 payloads (#9916) * Update bizzclickBidAdapter.js * Update rubiconBidAdapter.js * Update gothamadsBidAdapter.js * Update luponmediaBidAdapter.js * Update ozoneBidAdapter.js * Update pubmaticBidAdapter.js * Update improvedigitalBidAdapter.js * Update newspassidBidAdapter.js * Update deltaprojectsBidAdapter.js * Update bizzclickBidAdapter.js * Update deltaprojectsBidAdapter.js * Update gothamadsBidAdapter.js * Update luponmediaBidAdapter.js * Update newspassidBidAdapter.js * Update ozoneBidAdapter.js * Update pubmaticBidAdapter.js * Update rubiconBidAdapter.js * Update improvedigitalBidAdapter_spec.js * Update luponmediaBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update improvedigitalBidAdapter.js * Update pubmaticBidAdapter.js * Update improvedigitalBidAdapter.js * Update pubmaticBidAdapter.js * Update pubmaticBidAdapter.js * Update pubmaticBidAdapter_spec.js * Update adtrueBidAdapter.js * Update adtrueBidAdapter_spec.js * Update adtrueBidAdapter.js * Update adtrueBidAdapter_spec.js * Update adtrueBidAdapter_spec.js * Do not call onBidViewable, onBidWon, etc for S2S bids (#9919) * Access x_source.tid from ortb2 object (#9960) * Access x_source.tid from ortb2 object * Fix lint errors * Prebid 8: set pubmatic source.tid to auctionId (#9954) * set source.tid to auctionId * removed changes to test page * added support for setting ext.wrapper.transactionId as well * Prebid 8: use `prebid.floors.floorMin` instead of `prebid.floorMin` (#9899) * Prebid 8: remove shutdown company from appnexus aliases (#9977) * Update appnexusBidAdapter.js * Update appnexusBidAdapter.js * add bidResponse before emitting the event BID_RESPONSE, so that the bid is stored in the auction instance when the event is triggered (#9847) * Multiple modules: use `ortb2.source.tid` and `ortb2Imp.ext.tid` instead of auctionId/transactionId (#9969) * adkernel * aidem * beop * bliink * criteo * feedad * grid * kargo * medianet * optidigital * rubicon * smilewanted * Multiple modules: use `ortb2.source.tid` and `ortb2Imp.ext.tid` instead of auction/transaction IDs * tappx * onetag * use bidderRequestId instead of generateUUID * Epsilon - Prebid v8 changes to remove documentation in coding project (#9966) Co-authored-by: aarprice@publicisgroupe.net <aaron.price@epsilon.com> * Prebid 8: pick keywords from FPD in addition to bid params (#9917) * extract appnexus-style keyword logic into its own library * refactor appnexus clones to share keyword logic * pick keywords from ortb2 in addition to bid params * Prebid 8: support sizeMapping for video; extract it into a module (#9893) * Core: support sizeMapping for video * make sizeMapping a module * Magnite Analytics Adapter : do not rely on BID_RESPONSE 0cpm rejected bids (#9933) * Magnite Analytics - Do not rely on BID_RESPONSE for rejected bids * use rejection floor constant! * Remove AOL bid adapter (#10030) Co-authored-by: slimkrazy <sam@slimkrazy.com> * AdTelligent Bid Adapter: remove onefiftytwo alias (#10025) * Smartadserver Bid Adapter: support GPID (#10004) * Smartadserver Bid Adapter: Add support for SDA user and site * Smartadserver Bid Adapter: Fix SDA support getConfig and add to unit testing * support floors per media type * Add GPP support * Rework payloads enriching * Add gpid support --------- Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> * chore: update default video placement value [PB-1560] (#9948) Co-authored-by: Chris Corbo <chris.corbo@indexexchange.com> * ShareThrough Bid Adapter : fix playerSize (#10011) * fix sharethrough playersize * fix unit test --------- Co-authored-by: Reinout Stevens <reinout@crazygames.com> * GrowthCode RTD : initial release (#9852) * The New RTD Module * GrowthCode new RTD Module * Fixed to Prebid Added Testing Added Docs * Fixed to Prebid Added Testing Added Docs * Completed testing spec * Update the MD file to provide more infomation about what the module does * Update sample to point to the correct server for testing. * Stv Bid Adapter: add schain support (#10010) * initial commit * adapted buildRequests function * refinement pfilter and bcat * refinement * adapted tests for isBidRequestValid,buildRequests * adaptations for test * finished building stvBidAdapter.js * finished: ran tests, coverage 99% * update: rename w->srw, h->srh * adapt stvBidAdapter.md * remove dspx from stv adapters * some changes (missing: getUserSyncs, but is the same as in radsBidAdapter) * added checks in getUserSyncs; ran tests * added schain support (94.8% coverage) * correct schain encoding --------- Co-authored-by: theo_ <theo_@IDEA3> * fix module type (#10019) * Update ad generation adapter 1.6.0: update userSync (#9984) * Update AdGenerationAdapter: update userSync * update test spec * remove onefiftytwo alias --------- Co-authored-by: Krzysztof Sokół <88041828+krzysztofequativ@users.noreply.github.com> Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> Co-authored-by: ccorbo <ccorbo2013@gmail.com> Co-authored-by: Chris Corbo <chris.corbo@indexexchange.com> Co-authored-by: Reinout Stevens <518971+ReinoutStevens@users.noreply.github.com> Co-authored-by: Reinout Stevens <reinout@crazygames.com> Co-authored-by: southern-growthcode <79725079+southern-growthcode@users.noreply.github.com> Co-authored-by: theo-stv <120092078+theo-stv@users.noreply.github.com> Co-authored-by: theo_ <theo_@IDEA3> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Takaaki.Kojima <banakemi@gmail.com> * Revert "AdTelligent Bid Adapter: remove onefiftytwo alias (#10025)" (#10032) This reverts commit 88dbc04. * Prebid 8: update PBS adapter defaults to signal support for native js trackers (#9900) * Prebid 8: introduce new `transmitTid` activity control (#10034) * Core: introduce new `transmitTid` activity control and turn off TIDs by default * enable TIDs for e2e tests * set session_id param based on the bidderRequestId (#10049) Co-authored-by: Patrick McCann <patmmccann@gmail.com> * appnexus bid adapter - update logic banner adtype in request (#10048) * Prebid 8: do not keep previous floor data on subsequent `setConfig`s (#10051) * Prebid 8: remove NO_BID bids (#9902) * remove NO_BID bids: currency * remove NO_BID bids: priceFloors * remove NO_BID bids: PBS * remove NO_BID status * fix lint * Utiq: Update domain resolving logic and tests (#10044) Co-authored-by: Tomasz Januszek <tomasz@teavaro.com> * Prebid 8: Enforcement, lat and long can only come from the request (#10041) * Update apacdexBidAdapter.js * Update ebdrBidAdapter.js * Update mediafuseBidAdapter.js * Update microadBidAdapter.js * Update zetaBidAdapter.js * Update pubwiseBidAdapter.js * Update pubmaticBidAdapter.js * Update ebdrBidAdapter.js * Update microadBidAdapter.js * Update apacdexBidAdapter.js * Update apacdexBidAdapter_spec.js * Update mediafuseBidAdapter_spec.js * Update pubmaticBidAdapter_spec.js * Update microadBidAdapter_spec.js * Update pubmaticBidAdapter_spec.js * Update pubmaticBidAdapter_spec.js * Prebid 8: remove GDPR check when GDPR enforcement is disabled (#10050) * Cadent Bid Adapter: rename emxdigital to cadent (#10069) * rename files * rename bidder_code * rename adapter object * rename remaining references * add alias from emx_digital --------- Co-authored-by: Michael Denton <mdenton@cadent.tv> * IX Bid Adapter: remove transactionid usage in complience with prebid 8 [PB-1743] (#10070) Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * Update cadentApertureMXBidAdapter.js * Prebid 8: Remove Captify (#10072) * Delete captifyRtdProvider.md * Delete captifyRtdProvider_spec.js * Delete captifyRtdProvider_example.html * Delete captifyRtdProvider.js * Update kargoBidAdapter.js * AdagioBidAdapter: prebid-8: stop using auctionid and transactionid (#10079) * AdagioBidAdapter: stop using Prebid.js internal auctionId and transactionId * AdagioBidAdapter: remove transformBidParams() logic * Criteo Bid Adapter : remove usage of bidRequest.auctionId (#10084) * Grid Bid Adapter : removed embedded criteo bid adapter (#10088) * prebid 8 - read ortb segment data in appnexus keywords library functions (#10082) * prebid8 - read ortb segment data in appnexus keywords library functions * remove null condition from segtax map * airgrid RTD provider: use data segments instead of keywords, remove bidder specific handling (#10080) * Prebid 8: improve `transmitTid` logic for PBS adapter (#10092) * Prebid 8: remove bidder specific handling for 1plusX (#10093) * 1plusX: Do not set keywords for appnexus * weborama: remove appnexus specific handling * remove key=value keyword parsing for appnexus and its clones * fix lint * use 1plusX instead of 1plusx * Revert "remove key=value keyword parsing for appnexus and its clones" This reverts commit 80567cd. * Revert "weborama: remove appnexus specific handling" This reverts commit d6450d1. * 1plusX: add segtax to user data * Update codeql-analysis.yml --------- Co-authored-by: jkthomas <tom.januszek@gmail.com> Co-authored-by: Tomasz Januszek <tomasz@teavaro.com> Co-authored-by: prashuc <105750978+prashuc@users.noreply.github.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Timothy Ace <github.com-1@timothyace.com> Co-authored-by: Timothy M. Ace <tace@imds.tv> Co-authored-by: Pratik Chavan <pchavan@imds.tv> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com> Co-authored-by: Robert Ray Martinez III <rrmartinez1552@gmail.com> Co-authored-by: Andrew Slagle <42588549+spotxslagle@users.noreply.github.com> Co-authored-by: Jason Quaccia <jlquaccia@gmail.com> Co-authored-by: olafbuitelaar <olaf.buitelaar@gmail.com> Co-authored-by: Aaron Price <67345931+AaronColbyPrice@users.noreply.github.com> Co-authored-by: aarprice@publicisgroupe.net <aaron.price@epsilon.com> Co-authored-by: Samuel Adu <samuel.adu@gmail.com> Co-authored-by: slimkrazy <sam@slimkrazy.com> Co-authored-by: Gena <wertixvost@gmail.com> Co-authored-by: Krzysztof Sokół <88041828+krzysztofequativ@users.noreply.github.com> Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> Co-authored-by: ccorbo <ccorbo2013@gmail.com> Co-authored-by: Chris Corbo <chris.corbo@indexexchange.com> Co-authored-by: Reinout Stevens <518971+ReinoutStevens@users.noreply.github.com> Co-authored-by: Reinout Stevens <reinout@crazygames.com> Co-authored-by: southern-growthcode <79725079+southern-growthcode@users.noreply.github.com> Co-authored-by: theo-stv <120092078+theo-stv@users.noreply.github.com> Co-authored-by: theo_ <theo_@IDEA3> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Takaaki.Kojima <banakemi@gmail.com> Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com> Co-authored-by: EMX Digital <43830380+EMXDigital@users.noreply.github.com> Co-authored-by: Michael Denton <mdenton@cadent.tv> Co-authored-by: shahinrahbariasl <56240400+shahinrahbariasl@users.noreply.github.com> Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> Co-authored-by: Olivier <osazos@adagio.io> Co-authored-by: Léonard Labat <le.labat@criteo.com>
musikele
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
Aug 28, 2023
* Prebid 8: Delete Inskin (prebid#9868) * Delete inskinBidAdapter.js * Delete inskinBidAdapter.md * Delete inskinBidAdapter_spec.js * Prebid 8: Renaming TrustPid User ID module to Utiq (prebid#9872) * feature: Add trustpid user id module * refactor: Update trustpidSystem module, comments and md file * refactor: Update trustpidSystem file to handle domain setting regardless of message events * refactor: Update trustpidSystem module and dependent tests and docs * refactor: Update trustpid undefined checks and returns * tests: Update trustpid tests * docs: Update trustpid docs typo * refactor: Update trustpid acronyms logic * TrustPid: Remove deprecated acronyms logic * Rename TrustPid User ID module to Utiq --------- Co-authored-by: Tomasz Januszek <tomasz@teavaro.com> * RTB-2173: Removing Inmar from Prebid (prebid#8913) * Delete viewability.js (prebid#9873) * Prebid 8: Delete realvu (prebid#9867) * Delete realvuAnalyticsAdapter_spec.js * Delete realvuAnalyticsAdapter.md * Delete realvuAnalyticsAdapter.js * Prebid 8: Delete pubcid (prebid#9869) * Realvu analytics adapter: fix test failures on Edge (prebid#9857) * Realvu analytics adapter: fix test failures on Edge * Remove realVu tests * Delete pubCommonId.js * Delete pubCommonId.md * Delete pubCommonId_spec.js --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> * Prebid 8: Delete openxortb and analytics (prebid#9864) * Delete openxOrtbBidAdapter.js * Delete openxOrtbBidAdapter.md * Delete openxOrtbBidAdapter_spec.js * Update openxBidAdapter_spec.js * Delete openxAnalyticsAdapter.js * Delete openxAnalyticsAdapter.md * Delete openxAnalyticsAdapter_spec.js * Core & multiple modules: populate ortb2.source.tid (prebid#9862) * Core & multiple modules: populate ortb2.source.tid * enable codeql for prebid-8 * Prebid 8: IMDS bid adapter - Rename synacormedia adapter (prebid#9381) * CAPT-252: Synacormedia bid adapter: add tmax to requests based upon provided timeouts. * Re-brand synacormedia adapter to imds (iMedia Digitial Services) * Add alias to synacormedia for backwards compatibility --------- Co-authored-by: Timothy M. Ace <tace@imds.tv> Co-authored-by: Pratik Chavan <pchavan@imds.tv> * Prebid 8: Dead Module removal (prebid#9887) * Delete liveyieldAnalyticsAdapter_spec.js * Delete liveyieldAnalyticsAdapter.md * Delete liveyieldAnalyticsAdapter.js * Delete glimpseBidAdapter.js * Delete glimpseBidAdapter.md * Delete glimpseBidAdapter_spec.js * Prebid 8: Delete GA analytics - universal analytics (prebid#9866) * Delete googleAnalyticsAdapter.js * Delete googleAnalyticsAdapter.md * Delete googleAnalyticsAdapter_spec.js * Prebid 8: Delete zeus (prebid#9874) * Delete zeusPrimeRtdProvider.md * Delete zeusPrimeRtdProvider.js * Prebid 8: remove special augmentation of `auctionInit` event (prebid#9897) * Prebid 8 - deprecate bidder category translation feature in core (prebid#9898) * prebid 8 - deprecate category translation in core * remove storage export and move mapping data to library file * Prebid 8: Delete adgeneration (prebid#9904) * Delete adgenerationBidAdapter_spec.js * Delete adgenerationBidAdapter.md * Delete adgenerationBidAdapter.js * Prebid 8: do not use hardcoded `bidderCode` in resposes from bid adapters (prebid#9905) * Revert "Prebid 8: Delete adgeneration (prebid#9904)" (prebid#9915) This reverts commit ce984b3. * Prebid 8: No mas mass (prebid#9909) * Delete index.html * Delete mass_spec.js * Delete mass.md * Delete mass.js * Prebid 8: Delete emx (prebid#9918) * Delete emx_digitalBidAdapter.js * Delete emx_digitalBidAdapter.md * Delete emx_digitalBidAdapter_spec.js * Remove Rubicon Analytics for Prebid 8 (prebid#9932) * Prebid 8: stop using transactionId as source.tid on ortb2 payloads (prebid#9916) * Update bizzclickBidAdapter.js * Update rubiconBidAdapter.js * Update gothamadsBidAdapter.js * Update luponmediaBidAdapter.js * Update ozoneBidAdapter.js * Update pubmaticBidAdapter.js * Update improvedigitalBidAdapter.js * Update newspassidBidAdapter.js * Update deltaprojectsBidAdapter.js * Update bizzclickBidAdapter.js * Update deltaprojectsBidAdapter.js * Update gothamadsBidAdapter.js * Update luponmediaBidAdapter.js * Update newspassidBidAdapter.js * Update ozoneBidAdapter.js * Update pubmaticBidAdapter.js * Update rubiconBidAdapter.js * Update improvedigitalBidAdapter_spec.js * Update luponmediaBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update improvedigitalBidAdapter.js * Update pubmaticBidAdapter.js * Update improvedigitalBidAdapter.js * Update pubmaticBidAdapter.js * Update pubmaticBidAdapter.js * Update pubmaticBidAdapter_spec.js * Update adtrueBidAdapter.js * Update adtrueBidAdapter_spec.js * Update adtrueBidAdapter.js * Update adtrueBidAdapter_spec.js * Update adtrueBidAdapter_spec.js * Do not call onBidViewable, onBidWon, etc for S2S bids (prebid#9919) * Access x_source.tid from ortb2 object (prebid#9960) * Access x_source.tid from ortb2 object * Fix lint errors * Prebid 8: set pubmatic source.tid to auctionId (prebid#9954) * set source.tid to auctionId * removed changes to test page * added support for setting ext.wrapper.transactionId as well * Prebid 8: use `prebid.floors.floorMin` instead of `prebid.floorMin` (prebid#9899) * Prebid 8: remove shutdown company from appnexus aliases (prebid#9977) * Update appnexusBidAdapter.js * Update appnexusBidAdapter.js * add bidResponse before emitting the event BID_RESPONSE, so that the bid is stored in the auction instance when the event is triggered (prebid#9847) * Multiple modules: use `ortb2.source.tid` and `ortb2Imp.ext.tid` instead of auctionId/transactionId (prebid#9969) * adkernel * aidem * beop * bliink * criteo * feedad * grid * kargo * medianet * optidigital * rubicon * smilewanted * Multiple modules: use `ortb2.source.tid` and `ortb2Imp.ext.tid` instead of auction/transaction IDs * tappx * onetag * use bidderRequestId instead of generateUUID * Epsilon - Prebid v8 changes to remove documentation in coding project (prebid#9966) Co-authored-by: aarprice@publicisgroupe.net <aaron.price@epsilon.com> * Prebid 8: pick keywords from FPD in addition to bid params (prebid#9917) * extract appnexus-style keyword logic into its own library * refactor appnexus clones to share keyword logic * pick keywords from ortb2 in addition to bid params * Prebid 8: support sizeMapping for video; extract it into a module (prebid#9893) * Core: support sizeMapping for video * make sizeMapping a module * Magnite Analytics Adapter : do not rely on BID_RESPONSE 0cpm rejected bids (prebid#9933) * Magnite Analytics - Do not rely on BID_RESPONSE for rejected bids * use rejection floor constant! * Remove AOL bid adapter (prebid#10030) Co-authored-by: slimkrazy <sam@slimkrazy.com> * AdTelligent Bid Adapter: remove onefiftytwo alias (prebid#10025) * Smartadserver Bid Adapter: support GPID (prebid#10004) * Smartadserver Bid Adapter: Add support for SDA user and site * Smartadserver Bid Adapter: Fix SDA support getConfig and add to unit testing * support floors per media type * Add GPP support * Rework payloads enriching * Add gpid support --------- Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> * chore: update default video placement value [PB-1560] (prebid#9948) Co-authored-by: Chris Corbo <chris.corbo@indexexchange.com> * ShareThrough Bid Adapter : fix playerSize (prebid#10011) * fix sharethrough playersize * fix unit test --------- Co-authored-by: Reinout Stevens <reinout@crazygames.com> * GrowthCode RTD : initial release (prebid#9852) * The New RTD Module * GrowthCode new RTD Module * Fixed to Prebid Added Testing Added Docs * Fixed to Prebid Added Testing Added Docs * Completed testing spec * Update the MD file to provide more infomation about what the module does * Update sample to point to the correct server for testing. * Stv Bid Adapter: add schain support (prebid#10010) * initial commit * adapted buildRequests function * refinement pfilter and bcat * refinement * adapted tests for isBidRequestValid,buildRequests * adaptations for test * finished building stvBidAdapter.js * finished: ran tests, coverage 99% * update: rename w->srw, h->srh * adapt stvBidAdapter.md * remove dspx from stv adapters * some changes (missing: getUserSyncs, but is the same as in radsBidAdapter) * added checks in getUserSyncs; ran tests * added schain support (94.8% coverage) * correct schain encoding --------- Co-authored-by: theo_ <theo_@IDEA3> * fix module type (prebid#10019) * Update ad generation adapter 1.6.0: update userSync (prebid#9984) * Update AdGenerationAdapter: update userSync * update test spec * remove onefiftytwo alias --------- Co-authored-by: Krzysztof Sokół <88041828+krzysztofequativ@users.noreply.github.com> Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> Co-authored-by: ccorbo <ccorbo2013@gmail.com> Co-authored-by: Chris Corbo <chris.corbo@indexexchange.com> Co-authored-by: Reinout Stevens <518971+ReinoutStevens@users.noreply.github.com> Co-authored-by: Reinout Stevens <reinout@crazygames.com> Co-authored-by: southern-growthcode <79725079+southern-growthcode@users.noreply.github.com> Co-authored-by: theo-stv <120092078+theo-stv@users.noreply.github.com> Co-authored-by: theo_ <theo_@IDEA3> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Takaaki.Kojima <banakemi@gmail.com> * Revert "AdTelligent Bid Adapter: remove onefiftytwo alias (prebid#10025)" (prebid#10032) This reverts commit 88dbc04. * Prebid 8: update PBS adapter defaults to signal support for native js trackers (prebid#9900) * Prebid 8: introduce new `transmitTid` activity control (prebid#10034) * Core: introduce new `transmitTid` activity control and turn off TIDs by default * enable TIDs for e2e tests * set session_id param based on the bidderRequestId (prebid#10049) Co-authored-by: Patrick McCann <patmmccann@gmail.com> * appnexus bid adapter - update logic banner adtype in request (prebid#10048) * Prebid 8: do not keep previous floor data on subsequent `setConfig`s (prebid#10051) * Prebid 8: remove NO_BID bids (prebid#9902) * remove NO_BID bids: currency * remove NO_BID bids: priceFloors * remove NO_BID bids: PBS * remove NO_BID status * fix lint * Utiq: Update domain resolving logic and tests (prebid#10044) Co-authored-by: Tomasz Januszek <tomasz@teavaro.com> * Prebid 8: Enforcement, lat and long can only come from the request (prebid#10041) * Update apacdexBidAdapter.js * Update ebdrBidAdapter.js * Update mediafuseBidAdapter.js * Update microadBidAdapter.js * Update zetaBidAdapter.js * Update pubwiseBidAdapter.js * Update pubmaticBidAdapter.js * Update ebdrBidAdapter.js * Update microadBidAdapter.js * Update apacdexBidAdapter.js * Update apacdexBidAdapter_spec.js * Update mediafuseBidAdapter_spec.js * Update pubmaticBidAdapter_spec.js * Update microadBidAdapter_spec.js * Update pubmaticBidAdapter_spec.js * Update pubmaticBidAdapter_spec.js * Prebid 8: remove GDPR check when GDPR enforcement is disabled (prebid#10050) * Cadent Bid Adapter: rename emxdigital to cadent (prebid#10069) * rename files * rename bidder_code * rename adapter object * rename remaining references * add alias from emx_digital --------- Co-authored-by: Michael Denton <mdenton@cadent.tv> * IX Bid Adapter: remove transactionid usage in complience with prebid 8 [PB-1743] (prebid#10070) Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * Update cadentApertureMXBidAdapter.js * Prebid 8: Remove Captify (prebid#10072) * Delete captifyRtdProvider.md * Delete captifyRtdProvider_spec.js * Delete captifyRtdProvider_example.html * Delete captifyRtdProvider.js * Update kargoBidAdapter.js * AdagioBidAdapter: prebid-8: stop using auctionid and transactionid (prebid#10079) * AdagioBidAdapter: stop using Prebid.js internal auctionId and transactionId * AdagioBidAdapter: remove transformBidParams() logic * Criteo Bid Adapter : remove usage of bidRequest.auctionId (prebid#10084) * Grid Bid Adapter : removed embedded criteo bid adapter (prebid#10088) * prebid 8 - read ortb segment data in appnexus keywords library functions (prebid#10082) * prebid8 - read ortb segment data in appnexus keywords library functions * remove null condition from segtax map * airgrid RTD provider: use data segments instead of keywords, remove bidder specific handling (prebid#10080) * Prebid 8: improve `transmitTid` logic for PBS adapter (prebid#10092) * Prebid 8: remove bidder specific handling for 1plusX (prebid#10093) * 1plusX: Do not set keywords for appnexus * weborama: remove appnexus specific handling * remove key=value keyword parsing for appnexus and its clones * fix lint * use 1plusX instead of 1plusx * Revert "remove key=value keyword parsing for appnexus and its clones" This reverts commit 80567cd. * Revert "weborama: remove appnexus specific handling" This reverts commit d6450d1. * 1plusX: add segtax to user data * Update codeql-analysis.yml --------- Co-authored-by: jkthomas <tom.januszek@gmail.com> Co-authored-by: Tomasz Januszek <tomasz@teavaro.com> Co-authored-by: prashuc <105750978+prashuc@users.noreply.github.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Timothy Ace <github.com-1@timothyace.com> Co-authored-by: Timothy M. Ace <tace@imds.tv> Co-authored-by: Pratik Chavan <pchavan@imds.tv> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com> Co-authored-by: Robert Ray Martinez III <rrmartinez1552@gmail.com> Co-authored-by: Andrew Slagle <42588549+spotxslagle@users.noreply.github.com> Co-authored-by: Jason Quaccia <jlquaccia@gmail.com> Co-authored-by: olafbuitelaar <olaf.buitelaar@gmail.com> Co-authored-by: Aaron Price <67345931+AaronColbyPrice@users.noreply.github.com> Co-authored-by: aarprice@publicisgroupe.net <aaron.price@epsilon.com> Co-authored-by: Samuel Adu <samuel.adu@gmail.com> Co-authored-by: slimkrazy <sam@slimkrazy.com> Co-authored-by: Gena <wertixvost@gmail.com> Co-authored-by: Krzysztof Sokół <88041828+krzysztofequativ@users.noreply.github.com> Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> Co-authored-by: ccorbo <ccorbo2013@gmail.com> Co-authored-by: Chris Corbo <chris.corbo@indexexchange.com> Co-authored-by: Reinout Stevens <518971+ReinoutStevens@users.noreply.github.com> Co-authored-by: Reinout Stevens <reinout@crazygames.com> Co-authored-by: southern-growthcode <79725079+southern-growthcode@users.noreply.github.com> Co-authored-by: theo-stv <120092078+theo-stv@users.noreply.github.com> Co-authored-by: theo_ <theo_@IDEA3> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Takaaki.Kojima <banakemi@gmail.com> Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com> Co-authored-by: EMX Digital <43830380+EMXDigital@users.noreply.github.com> Co-authored-by: Michael Denton <mdenton@cadent.tv> Co-authored-by: shahinrahbariasl <56240400+shahinrahbariasl@users.noreply.github.com> Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> Co-authored-by: Olivier <osazos@adagio.io> Co-authored-by: Léonard Labat <le.labat@criteo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Removed usage of auctionId and use instead source.tid or a random uuid.