Prebid 8: remove bidder specific handling for 1plusX

[dgirardi]

Type of change

• Other

Description of change

• update 1plusX to no longer generate key=value keywords for appnexus as it will pick up the segments with https://github.com/prebid/Prebid.js/pull/10082/files
• remove the logic from weborama as well. since weborama is not generating segments, this will break their appnexus integration.
• remove the key=value keyword parsing from appnexus and its clones.

[patmmccann]

@bwhisp fyi ; does this look cleaner to you?

[jsnellbaker]

See some inline comments below.

In addition for 1plusX - does their test page in the project (1plusXRtdProviderExample.html) include segment data? I don't see anything coming back in the ortb2 field within the appnexus bid adapter (see attached), so the data (if it's there) is not getting passed along to the new logic and to the endpoint.

[jsnellbaker]

To note - I am still unsure about removing this part of the functionality as it was previously in our adapter code, so it could have been used by someone for their setup and it would then stop sending the data properly to the endpoint.

Since it seemingly was approved by others in the community, I'm just mentioning this thought; it is not a blocker for the PR's acceptance.

[dgirardi]

You are correct, I thought this was never released but that's only true for the refactoring that included all the clones. I'll figure out if we want to keep it after all, to avoid the breaking change - standby.

[jsnellbaker]

Can we clarify with 1plusX how they passed their segment keywords previously? It seem like here it was with a keyname like 1plusX but the new logic has 1plusx. We should follow the same formatting as it was before.

[dgirardi]

fixed!

[jsnellbaker]

Don't have a good place to insert this comment; but from testing weborama they set their data in the site.ext.data instead of the ortb segment fields, so it's not getting included/read by the new logic for the appnexus bid adapter.

[dgirardi]

Correct, this is intentional and called out in the OP. If we end up keeping the key=value parsing I'll also undo this.

[bwhisp]

@bwhisp fyi ; does this look cleaner to you?

I checked the changes, looks great ! We're no longer doing specific things for a single bidder adapter
Thanks :)

[dgirardi]

does their test page in the project include segment data?

their endpoint doesn't, for me. so it tries to set no segments which gets validated out. Guessing that's what you see as well?

[dgirardi]

Updated to leave intact the key=value logic for appnexus keywords + weborama's use of it.

[jsnellbaker]

does their test page in the project include segment data?

their endpoint doesn't, for me. so it tries to set no segments which gets validated out. Guessing that's what you see as well?

I am seeing the same; @bwhisp is there something we can do or change in the test page to get the segment data populated so we can make sure the flow/transformation of the data via this PR works?

[dgirardi]

This is what appnexus sees if I mock out the network response with

{
          s: ['segment1', 'segment2', 'segment3'],
          t: ['targeting1', 'targeting2', 'targeting3']
}

Ends up in the appnexus request as:

s (which is populated under user.data) is lost because it does not have a segtax:

Prebid.js/modules/1plusXRtdProvider.js

Lines 153 to 161 in 41ee11b

	const userData = {
	name: ORTB2_NAME,
	segment: segments.map((segmentId) => ({ id: segmentId }))
	};
	const siteContentData = {
	name: ORTB2_NAME,
	segment: topics.map((topicId) => ({ id: topicId })),
	ext: { segtax: segtaxes.CONTENT }
	}

@bwhisp is this intentional?

[dgirardi]

updated to add the audience segtax to user.data .

[bwhisp]

Hi @jsnellbaker @dgirardi
The endpoint you mentioned is supposed to give us some data
I will check it in the next few days.

[patmmccann]

@bwhisp thanks! in the meantime, it appears from mocking your endpoint we're good to go. We appreciate the conversion over!

[jsnellbaker]

Approving this PR based on the mocked data that @dgirardi tested and provided.

[bwhisp]

@patmmccann @jsnellbaker @dgirardi
we could create some data for the /targeting endpoint

I might also need to change the extension 1plusXRTDProviderExample.html to xhtml
Do you think it's feasible ?