Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mediaimpact Bid Adapter: move advertiserDomains, primaryCatId, secondaryCatIds to ad.meta #11637

Merged
merged 10 commits into from
Jun 3, 2024
Merged

Mediaimpact Bid Adapter: move advertiserDomains, primaryCatId, secondaryCatIds to ad.meta #11637

merged 10 commits into from
Jun 3, 2024

Conversation

nalexand
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@nalexand
Copy link
Contributor Author

nalexand commented May 31, 2024 •
edited
Loading

How to rerun tests?
Chrome 87.0.4280.66 (Windows 10): Executed 15890 of 15887 (skipped 1) SUCCESS (1 min 14.152 secs / 32.404 secs)
Safari 14.1.2 (Mac OS 10.15.7): Executed 15840 of 15887 (skipped 1) SUCCESS (1 min 57.56 secs / 1 min 21.836 secs)
Firefox 126.0 (Windows 10): Executed 0 of 0 DISCONNECTED (40 mins 32.104 secs / 0 secs)
Edge 125.0.0.0 (Windows 10): Executed 15890 of 15887 (skipped 1) SUCCESS (53.768 secs / 26.611 secs)
Chrome 125.0.0.0 (Windows 10): Executed 15890 of 15887 (skipped 1) SUCCESS (51.495 secs / 24.743 secs)
Safari 13.1.2 (Mac OS 10.15.6): Executed 15890 of 15887 (skipped 1) SUCCESS (1 min 13.69 secs / 55.83 secs)

@ChrisHuie
Copy link
Collaborator

How to rerun tests? Chrome 87.0.4280.66 (Windows 10): Executed 15890 of 15887 (skipped 1) SUCCESS (1 min 14.152 secs / 32.404 secs) Safari 14.1.2 (Mac OS 10.15.7): Executed 15840 of 15887 (skipped 1) SUCCESS (1 min 57.56 secs / 1 min 21.836 secs) Firefox 126.0 (Windows 10): Executed 0 of 0 DISCONNECTED (40 mins 32.104 secs / 0 secs) Edge 125.0.0.0 (Windows 10): Executed 15890 of 15887 (skipped 1) SUCCESS (53.768 secs / 26.611 secs) Chrome 125.0.0.0 (Windows 10): Executed 15890 of 15887 (skipped 1) SUCCESS (51.495 secs / 24.743 secs) Safari 13.1.2 (Mac OS 10.15.6): Executed 15890 of 15887 (skipped 1) SUCCESS (1 min 13.69 secs / 55.83 secs)

Rerunning

@ChrisHuie ChrisHuie self-assigned this Jun 3, 2024
@ChrisHuie ChrisHuie merged commit 74c8644 into prebid:master Jun 3, 2024
4 checks passed
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
@nalexand @DecayConstant
Mediaimpact Bid Adapter: move advertiserDomains, primaryCatId, second…
5a12b5c 
…aryCatIds to ad.meta (prebid#11637)

* Add mediaimpact bid adapter

* Add mediaimpact bid adapter tests

* Add custom sizes

* Refactor response meta

* mediaimpact adapter fix tests

---------

Co-authored-by: koshe <koshelev.alexandr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHuie ChrisHuie ChrisHuie approved these changes

Assignees

@ChrisHuie ChrisHuie

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalexand @ChrisHuie