Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mediaimpact Bid Adapter: move advertiserDomains, primaryCatId, secondaryCatIds to ad.meta #11637

Merged
merged 10 commits into from
Jun 3, 2024
Merged

Mediaimpact Bid Adapter: move advertiserDomains, primaryCatId, secondaryCatIds to ad.meta #11637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3750395
Add mediaimpact bid adapter
Feb 13, 2024
26e4dc9
Add mediaimpact bid adapter tests
Feb 13, 2024
96e54f1
Merge branch 'prebid:master' into master
nalexand Feb 14, 2024
363339e
Merge branch 'prebid:master' into master
nalexand Mar 25, 2024
cecb514
Add custom sizes
Mar 25, 2024
072edef
Merge branch 'prebid:master' into master
nalexand Apr 16, 2024
2320c28
Merge branch 'prebid:master' into master
nalexand May 29, 2024
e135264
Refactor response meta
May 31, 2024
2d4fcde
Merge branch 'master' of https://github.com/nalexand/Prebid.js
May 31, 2024
fc9915a
mediaimpact adapter fix tests
May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions modules/mediaimpactBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,12 @@ export const spec = {
creativeId: ad.creativeId,
netRevenue: ad.netRevenue,
currency: ad.currency,
winNotification: ad.winNotification
}
winNotification: ad.winNotification,
meta: {}
};

bidObject.meta = {};
if (ad.adomain && ad.adomain.length > 0) {
bidObject.meta.advertiserDomains = ad.adomain;
if (ad.meta) {
bidObject.meta = ad.meta;
}

return bidObject;
Expand Down
18 changes: 9 additions & 9 deletions test/spec/modules/mediaimpactBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,9 @@ describe('MediaimpactAdapter', function () {
'width': 300,
'height': 250,
'creativeId': '8:123456',
'adomain': [
'test.domain'
],
'meta': {
'advertiserDomains': ['test.domain']
},
'syncs': [
{'type': 'image', 'url': 'https://test.domain/tracker_1.gif'},
{'type': 'image', 'url': 'https://test.domain/tracker_2.gif'},
Expand Down Expand Up @@ -200,9 +200,9 @@ describe('MediaimpactAdapter', function () {
'cpm': 0.01,
'currency': 'USD',
'netRevenue': true,
'adomain': [
'test.domain'
],
'meta': {
'advertiserDomains': ['test.domain']
},
};

it('fill ad for response', function () {
Expand Down Expand Up @@ -263,9 +263,9 @@ describe('MediaimpactAdapter', function () {
'width': 300,
'height': 250,
'creativeId': '8:123456',
'adomain': [
'test.domain'
],
'meta': {
'advertiserDomains': ['test.domain']
},
'syncs': [
{'type': 'image', 'link': 'https://test.domain/tracker_1.gif'},
{'type': 'image', 'link': 'https://test.domain/tracker_2.gif'},
Expand Down