Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beachfront adapter - add ad unit size #1183

Merged
merged 21 commits into from
May 19, 2017
Merged

Beachfront adapter - add ad unit size #1183

merged 21 commits into from
May 19, 2017

Conversation

bfmdeploy
Copy link
Contributor

Type of change

  • Feature

Description of change

Added ad unit size to bid request for the Beachfront adapter.

@snapwich snapwich self-requested a review May 16, 2017 22:28
@mkendall07
Copy link
Member

@bfmdeploy
we just updated code style, please rebase from master then we can merge. THanks

Matt Kendall and others added 19 commits May 18, 2017 17:17
Merge branch 'master' into update-beachfront-adapter
e77418e
Fixed lint errors
f392a6c
Added ad unit size to bid request
3b0082b
Add trafficSourceCode + test (prebid#1184)
3c2027a
Prebid 0.23.1 Release
b2798f4
pre release version bump
c358ebe
inclusion of popular Nordic ad sizes to default size list (prebid#1168)
c73e458 
inclusion of popularNordic ad sizes to default size list

Removed redundant 104 size and added size 32 instead

Fixed trailing comma
@GLStephen
Add PubWise Analytics (prebid#1151)
cb67cf8 
* PubWise Analytics

* Updates based on Feedback
@snapwich
add new rp_secure param to rubicon adapter (prebid#1190)
c7a3d8e
Add type conversion into PrebidServer to handle inconsistent types. (p…
b68af07 
…rebid#1195)

* Add type conversion into prebxdserver to handle inconsistent types.

* Only check for params that exist.

* adding test

* fix string conversion and add unit tests

* fix for code review

* add debug output

* remove accidental commit

* newline
@canyousayyes
Bug fix: bids served by secure creatives does not get pushed into _wi…
21d8a22 
…nningBids (prebid#1192)
Add dynamic bidfloor parameter to Smart Adserver Adapter (prebid#1194)
bd169bf 
* Smart AdServer adapter

Add Smart AdServer adapter with tests

* fix not supported method

Replace startsWith which is not supported in all browser version by
lastIndexOf.

* Issue with optional parameter

Fix issue when no targeting is specified and remove "undefined" value
passed in url

* Add dynamic bidfloor option in the SmartAdServer prebid call.
@matthewlane
Upgrade linters to ESLint with stricter code style (prebid#1111)
e8be4ac 
* Upgraded to ESLint with stricter code style, for both sources and tests
* Updated some dependencies and the yarn.lock file
@grevory
Add Support for DigiTrust in Rubicon Adapter (prebid#1201)
73d5bf6 
* Add support for DigiTrust

* Add rubicon tests covering digitrust failures

* Remove whitespace in Rubicon adapter
@ronenst
HIRO Media: Remove batching mechanism and use AJAX instead of JSONP (p…
4f072e3 
…rebid#1133)

* Remove batching mechanism and use AJAX instead of JSONP

* Fix `undefined` value checks
@grevory
Rename secureCreatives file and lint (prebid#1203)
b025d54 
* Rename secureCreatives file and lint

* Updated package script for linting

* Use 'gulp run-tests' in package script for testing
@ckbo3hrk
Common user-sync (prebid#1144)
95bbfc5
@jaiminpanchal27
updated tag (prebid#1212)
6f4f4d4
Merge branch 'update-beachfront-adapter' of https://github.com/bfmdep…
420d921 
…loy/Prebid.js into update-beachfront-adapter
@bfmdeploy
Copy link
Contributor Author

@mkendall07
Hi, I fixed the lint errors and attempted a rebase from master because the build was failing.

mkendall07
mkendall07 reviewed May 19, 2017
View reviewed changes
src/adapters/beachfront.js Outdated
@@ -14,7 +14,7 @@ function BeachfrontAdapter() {
const bids = bidRequests.bids || [];
bids.forEach(function(bid) {
var bidRequest = getBidRequest(bid);
var RTBDataParams = prepareAndSaveRTBRequestParams(bid);
var RTBDataParams = prepareAndSaveRTBRequestParams(bidRequest);
Copy link
Member

@mkendall07 mkendall07 May 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should still be bid ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to bidRequest because it has the parsed width and height properties.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok but doesn't it just return here because bid.params doesn't exist?
https://github.com/bfmdeploy/Prebid.js/blob/420d921c0db56f06f87bb5004d3ba8dc3f1e4b13/src/adapters/beachfront.js#L46

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bid.params should exist. I think the confusion here is that bid and bidRequest are referencing the same object. I can revert that line if it makes it more clear.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right. Yeah that's a bit confusing... I would just make it bid to clear that up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge when you make the change

@mkendall07 mkendall07 merged commit 3f9ac58 into prebid:master May 19, 2017
@bfmdeploy bfmdeploy deleted the update-beachfront-adapter branch May 19, 2017 20:24
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request May 24, 2017
Merge branch 'master' of https://github.com/prebid/Prebid.js into pre…
26da027 
…built

* 'master' of https://github.com/prebid/Prebid.js: (23 commits)
  Increment pre version
  Probed 0.24.0 Release
  Beachfront adapter - add ad unit size (prebid#1183)
  Thoughtleadr adapter - fix postMessage (prebid#1207)
  When prebid server issues a no-bid response, call addBidResponse for every adUnit requested (prebid#1204)
  Improvement/timeout xhr (prebid#1172)
  Add native support (prebid#1072)
  Improvement/alias queue (prebid#1156)
  Updated documentaion (prebid#1160)
  Improvement/prebid iframes amp pages (prebid#1119)
  Fixes prebid#1114 possible xss issue (prebid#1186)
  Allowed setTargetingForGPTAsync() to target specific ad unit codes. (prebid#1158)
  updated tag (prebid#1212)
  Common user-sync (prebid#1144)
  Rename secureCreatives file and lint (prebid#1203)
  HIRO Media: Remove batching mechanism and use AJAX instead of JSONP (prebid#1133)
  Add Support for DigiTrust in Rubicon Adapter (prebid#1201)
  Upgrade linters to ESLint with stricter code style (prebid#1111)
  Add dynamic bidfloor parameter to Smart Adserver Adapter (prebid#1194)
  Bug fix: bids served by secure creatives does not get pushed into _winningBids (prebid#1192)
  ...
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request Jul 17, 2017
@vzhukovsky
Merge pull request prebid#109 in AOLP_ADS_JS/prebid.js from release/1…
ea3bf0f 
….23.0 to aolgithub-master

* commit '136fc37637749a764070c35c03e7e87a5c157947': (33 commits)
  Added changelog entry.
  Implemented passing key values feature.
  Update code to ESlint rules.
  Prebid 0.24.1 Release
  tests: drop ie9 browserstack test
  Audience Network: separate size from format (prebid#1218)
  Bugfix/target filtering api fix (prebid#1220)
  Map sponsor request param to endpoint param (prebid#1219)
  Increment pre version
  Probed 0.24.0 Release
  Beachfront adapter - add ad unit size (prebid#1183)
  Thoughtleadr adapter - fix postMessage (prebid#1207)
  When prebid server issues a no-bid response, call addBidResponse for every adUnit requested (prebid#1204)
  Improvement/timeout xhr (prebid#1172)
  Add native support (prebid#1072)
  Improvement/alias queue (prebid#1156)
  Updated documentaion (prebid#1160)
  Improvement/prebid iframes amp pages (prebid#1119)
  Fixes prebid#1114 possible xss issue (prebid#1186)
  Allowed setTargetingForGPTAsync() to target specific ad unit codes. (prebid#1158)
  ...
jbAdyoulike pushed a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017
@bfmdeploy @jbAdyoulike
Beachfront adapter - add ad unit size (prebid#1183)
f022ab6 
* Added ad unit size to bid request

* Fixed lint errors

* Added ad unit size to bid request

* Prebid 0.23.1 Release

* Add trafficSourceCode + test (prebid#1184)

* pre release version bump

* inclusion of popular Nordic ad sizes to default size list (prebid#1168)

inclusion of popularNordic ad sizes to default size list

Removed redundant 104 size and added size 32 instead

Fixed trailing comma

* Add PubWise Analytics (prebid#1151)

* PubWise Analytics

* Updates based on Feedback

* add new rp_secure param to rubicon adapter (prebid#1190)

* Add type conversion into PrebidServer to handle inconsistent types. (prebid#1195)

* Add type conversion into prebxdserver to handle inconsistent types.

* Only check for params that exist.

* adding test

* fix string conversion and add unit tests

* fix for code review

* add debug output

* remove accidental commit

* newline

* Add dynamic bidfloor parameter to Smart Adserver Adapter (prebid#1194)

* Smart AdServer adapter

Add Smart AdServer adapter with tests

* fix not supported method

Replace startsWith which is not supported in all browser version by
lastIndexOf.

* Issue with optional parameter

Fix issue when no targeting is specified and remove "undefined" value
passed in url

* Add dynamic bidfloor option in the SmartAdServer prebid call.

* Bug fix: bids served by secure creatives does not get pushed into _winningBids (prebid#1192)

* Upgrade linters to ESLint with stricter code style (prebid#1111)

* Upgraded to ESLint with stricter code style, for both sources and tests
* Updated some dependencies and the yarn.lock file

* Add Support for DigiTrust in Rubicon Adapter (prebid#1201)

* Add support for DigiTrust

* Add rubicon tests covering digitrust failures

* Remove whitespace in Rubicon adapter

* HIRO Media: Remove batching mechanism and use AJAX instead of JSONP (prebid#1133)

* Remove batching mechanism and use AJAX instead of JSONP

* Fix `undefined` value checks

* Rename secureCreatives file and lint (prebid#1203)

* Rename secureCreatives file and lint

* Updated package script for linting

* Use 'gulp run-tests' in package script for testing

* updated tag (prebid#1212)

* Common user-sync (prebid#1144)

* Changed “bidRequest” to “bid” for clarity
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@bfmdeploy @dluxemburg
Beachfront adapter - add ad unit size (prebid#1183)
f4a48e3 
* Added ad unit size to bid request

* Fixed lint errors

* Added ad unit size to bid request

* Prebid 0.23.1 Release

* Add trafficSourceCode + test (prebid#1184)

* pre release version bump

* inclusion of popular Nordic ad sizes to default size list (prebid#1168)

inclusion of popularNordic ad sizes to default size list

Removed redundant 104 size and added size 32 instead

Fixed trailing comma

* Add PubWise Analytics (prebid#1151)

* PubWise Analytics

* Updates based on Feedback

* add new rp_secure param to rubicon adapter (prebid#1190)

* Add type conversion into PrebidServer to handle inconsistent types. (prebid#1195)

* Add type conversion into prebxdserver to handle inconsistent types.

* Only check for params that exist.

* adding test

* fix string conversion and add unit tests

* fix for code review

* add debug output

* remove accidental commit

* newline

* Add dynamic bidfloor parameter to Smart Adserver Adapter (prebid#1194)

* Smart AdServer adapter

Add Smart AdServer adapter with tests

* fix not supported method

Replace startsWith which is not supported in all browser version by
lastIndexOf.

* Issue with optional parameter

Fix issue when no targeting is specified and remove "undefined" value
passed in url

* Add dynamic bidfloor option in the SmartAdServer prebid call.

* Bug fix: bids served by secure creatives does not get pushed into _winningBids (prebid#1192)

* Upgrade linters to ESLint with stricter code style (prebid#1111)

* Upgraded to ESLint with stricter code style, for both sources and tests
* Updated some dependencies and the yarn.lock file

* Add Support for DigiTrust in Rubicon Adapter (prebid#1201)

* Add support for DigiTrust

* Add rubicon tests covering digitrust failures

* Remove whitespace in Rubicon adapter

* HIRO Media: Remove batching mechanism and use AJAX instead of JSONP (prebid#1133)

* Remove batching mechanism and use AJAX instead of JSONP

* Fix `undefined` value checks

* Rename secureCreatives file and lint (prebid#1203)

* Rename secureCreatives file and lint

* Updated package script for linting

* Use 'gulp run-tests' in package script for testing

* updated tag (prebid#1212)

* Common user-sync (prebid#1144)

* Changed “bidRequest” to “bid” for clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

@snapwich snapwich snapwich approved these changes

Assignees

@snapwich snapwich

@ndhimehta ndhimehta

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.