Audience Network: separate size from format #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovell
force-pushed
the
audience-network-size-vs-format
branch
from
854e3b6 to
aba63d9
Compare
protonate
requested review from
protonate and
jaiminpanchal27
and removed request for
protonate
protonate
approved these changes
May 25, 2017
| [bid.width, bid.height] = size.split('x').map(Number); | ||
| } | ||
| bid.ad = createAdHtml(placementId, format, bidId); | ||
| [bid.width, bid.height] = size.split('x').map(Number); |
There was a problem hiding this comment.
Nice bit of code there.
|
When debugging FB error response I noticed that here: https://github.com/lovell/Prebid.js/blob/aba63d940ae7600382139d4f9f9f3f08c5f39709/src/adapters/audienceNetwork.js#L169 any errors are logged using |
protonate
approved these changes
May 25, 2017
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Jul 17, 2017
….23.0 to aolgithub-master * commit '136fc37637749a764070c35c03e7e87a5c157947': (33 commits) Added changelog entry. Implemented passing key values feature. Update code to ESlint rules. Prebid 0.24.1 Release tests: drop ie9 browserstack test Audience Network: separate size from format (prebid#1218) Bugfix/target filtering api fix (prebid#1220) Map sponsor request param to endpoint param (prebid#1219) Increment pre version Probed 0.24.0 Release Beachfront adapter - add ad unit size (prebid#1183) Thoughtleadr adapter - fix postMessage (prebid#1207) When prebid server issues a no-bid response, call addBidResponse for every adUnit requested (prebid#1204) Improvement/timeout xhr (prebid#1172) Add native support (prebid#1072) Improvement/alias queue (prebid#1156) Updated documentaion (prebid#1160) Improvement/prebid iframes amp pages (prebid#1119) Fixes prebid#1114 possible xss issue (prebid#1186) Allowed setTargetingForGPTAsync() to target specific ad unit codes. (prebid#1158) ...
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this pull request
Sep 21, 2017
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Hello, this change is based on feedback from Prebid users and was commissioned and paid for by Facebook.
Some confusion has arisen due a mixture of size and format values in the Audience Network adaptor. This PR seeks to separate the two concerns by moving format to a parameter of its own instead of overloading the existing concept of size. This prevents formats specific to Audience Network being sent to other bidders as sizes.
There will be a separate PR for the associated documentation.
/cc @wheresbarney