Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greenbids Analytics : send cpm on any valid bid #12174

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

AlexisBRENON
Copy link
Contributor

@AlexisBRENON AlexisBRENON commented Aug 27, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Report bid CPM in all cases.

* fix(greenbids,analytics): cpm not passed

* bump version number
@ChrisHuie ChrisHuie changed the title fix(greenbids,analytics): send cpm on any valid bid Greenbids Analytics : send cpm on any valid bid Aug 28, 2024
@ChrisHuie
Copy link
Collaborator

@AlexisBRENON this seems to not be passing your unit tests

@AlexisBRENON
Copy link
Contributor Author

AlexisBRENON commented Aug 29, 2024

@ChrisHuie May you help me to run tests locally ?
I use the devcontainer environment.
I missed the ./.devcontainer/postCreate.sh step.

@ChrisHuie ChrisHuie merged commit 360c3ea into prebid:master Aug 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants