Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adxcg analytics adapter #1599

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Adxcg analytics adapter #1599

merged 1 commit into from
Oct 3, 2017

Conversation

adxcgcom
Copy link
Contributor

Type of change

  • New analytics adapter

Description of change

New adxcg analytics adapter.

  • test parameters for analytics adapter
{
  provider: 'adxcg',
  options: {
    publisherId: '42'
  }
}
  • contact email of the adapter’s maintainer
    info@adxcg.com
  • official adapter submission

Other information

protonate
protonate approved these changes Oct 2, 2017
View reviewed changes
Copy link
Collaborator

@protonate protonate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved, if you can fix the minor style note to use === that would be appreciated.

Tests are green, functionality confirmed, ship it.

modules/adxcgAnalyticsAdapter.js
data.auctionTimestamp = auctionTimestamp;

let location = utils.getTopWindowLocation();
let secure = location.protocol == 'https:';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we prefer triple equals

@mkendall07 mkendall07 merged commit e508a64 into prebid:master Oct 3, 2017
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request Oct 25, 2017
@vzhukovsky
Merge pull request prebid#128 in AOLP_ADS_JS/prebid.js from release/1…
ae0895f 
….30.0 to aolgithub-master

* commit '5a8d2bf93ee15071a78e24ac976103cacf3c6021': (35 commits)
  Added changelog entry.
  Prebid 0.30.1 Release
  Remove undefined variable usage (prebid#1662)
  fixes bug for IE when invalid value passed to parse (prebid#1657)
  Aliasbidder fix (prebid#1652)
  prebidAdapter secure support (prebid#1655)
  Increment pre version
  Prebid 0.30.0 Release
  Add native param support to mediaTypes (prebid#1625)
  PulsePoint Lite adpater changes (prebid#1630)
  Appnexus ast unittest updates (prebid#1654)
  Support aspect ratio specification for native images (prebid#1634)
  Revert changes for switch between client side and server side. (prebid#1653)
  rubicon converted to bidderFactory (prebid#1624)
  Add JSDoc for `pbjs.getAllWinningBids` (prebid#1566)
  Add ignore-loader to handle .md files (prebid#1646)
  fixed PBS cookie syncs (prebid#1637)
  Add placementId request param to Yieldmo bid adapter (prebid#1632)
  Adxcg analytics adapter (prebid#1599)
  Add publisher sub-id support to the Criteo adapter (prebid#1629)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@adxcgcom @dluxemburg
Adxcg analytics adapter (prebid#1599)
b38cfb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protonate protonate protonate approved these changes

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees

@protonate protonate

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adxcgcom @mkendall07 @protonate @matthewlane