fixed PBS cookie syncs

[harpere]

Type of change

• [x ] Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other

Description of change

• test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
• official adapter submission

Other information

[snapwich]

Sorry I'm late to the game here, but it seems like it would be ideal to have this sync code for the prebidServer adapter continue using the userSync.js module. If the issue is priority (it needs to run immediately) it seems like we should just code that use-case into userSync.js.

In all likelihood it's probably going to be a one-off, but if we need to make a one-off I think it's advantageous to put it in the place where you'd expect to find it, w/ the rest of the user sync code. If it ends up not being a one-off, now it's in a place that is reusable. Thoughts?

[mkendall07]

@snapwich I'd prefer not to have this patter in userSync.js to be honest. I think this is a good case for a one off.

[harpere]

@snapwich @mkendall07 I thought about adding this use case to userSync.registerSync(), but didn't think it was worth the added complication for a one-off. Also considered simply adding the new doBidderSync() function to userSync instead, but thought that might encourage bidders to use that instead of registerSync().

[mkendall07]

LGTM

[snapwich]

LGTM

[qrilka]

@harpere could you explain a bit the fact that in this PR you remove the only use of registerSync in the repo?
Do I understand it correctly that this function should be called but nobody does it?

[mkendall07]

@qrilka
The new pattern is to create a spec file and register it with the bidder factory. The spec should contain a getUserSyncs function which will invoke registerSync underneath.
Example:
https://github.com/prebid/Prebid.js/blob/master/modules/appnexusAstBidAdapter.js#L114
and
https://github.com/prebid/Prebid.js/blob/master/src/adapters/bidderFactory.js#L205

[qrilka]

thanks for the info @mkendall07
so the current docs are not correct talking about using both functions in http://prebid.org/dev-docs/bidder-adapter-1.html#register-user-syncs ? Also getUserSyncs on that page uses only 1 parameter while in the code I see responses as the 2nd one.