Safely reference native keyword to fix compression #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
approved these changes
Sep 27, 2017
dbemiller
approved these changes
Sep 27, 2017
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
nativeis a reserved word in ECMAScript v3. Its presence as a variable name, object property, and function name within Prebid was causing some compression tools to crash. This PR changes variables and functions that were namednativeto something else, and switches object lookups fornativeproperties from dot to bracket form.Testing notes
Tested on macOS 10.12 with Java 8 and
brew install yuicompressorBuilt prebid with
gulp servethan ran:On master this produces errors, on this PR the compression is successful
Other information
Fixes #1471