create some hooks and modify adServerManager function #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewlane
reviewed
Jan 31, 2019
src/prebid.js
Outdated
| } | ||
|
|
||
| if (mediaTypes && mediaTypes.native) { | ||
| const native = mediaTypes.native; |
There was a problem hiding this comment.
native as an identifier or object property can cause obscure issues because it was a reserved keyword in ECMAScript v3 -- may be a good time to update these references (in source files only, tests are fine). See #1621 for more info
There was a problem hiding this comment.
Thanks for the heads-up; I pushed a commit to rename this variable.
matthewlane
approved these changes
Feb 5, 2019
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* create hooks and modify adservermanager function * remove comment * modify the import path for hook file * move checkAdUnitSetup and refactor video.js hook * update hook code to use new API * change hooks to use sync type * add adpod mediatype and rename native variable * remove unused import from test file * remove adpod reference in utils to avoid merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR introduces a set of changes that's meant to lay-out some of the groundwork for #3379
Summary of the changes:
checkBidRequestSizesfunction to more generic namebuildVideoUrlproperty inadServerManager.js; now will support any property that's registered.