remove bidmanager from rubicon tests #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested changes
Oct 9, 2017
| var sizesBidderRequest = clone(bidderRequest); | ||
| sizesBidderRequest.bids[0].sizes = [[620, 250], [300, 251]]; | ||
|
|
||
| sandbox.stub(spec, 'buildRequests'); | ||
|
|
||
| rubiconAdapter.callBids(sizesBidderRequest); |
There was a problem hiding this comment.
This test can be easily tested by using spec.isBidRequestValid and spec.buildRequests. Call to callBids can be removed.
Same goes for other tests in for request test suite. They can be tested using spec functions.
jaiminpanchal27
requested changes
Oct 9, 2017
|
Updated. Also tested against 1.0 branch and everything passed there as well. |
dbemiller
reviewed
Oct 10, 2017
| @@ -191,39 +153,22 @@ describe('the rubicon adapter', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('callBids implementation', () => { | |||
| describe('buildRequests implementation', () => { | |||
| let rubiconAdapter; | |||
There was a problem hiding this comment.
I think you can get rid of the rubiconAdapter here, since your tests work on the spec
| @@ -1005,7 +816,6 @@ describe('the rubicon adapter', () => { | |||
| beforeEach(() => { | |||
| // monitor userSync registrations | |||
| userSyncStub = sandbox.stub(userSync, 'registerSync'); | |||
There was a problem hiding this comment.
Are you relying on this stub? If you're just testing the response of getUserSyncs, I don't think you should have to.
| @@ -128,43 +127,6 @@ describe('the rubicon adapter', () => { | |||
| sandbox.restore(); | |||
There was a problem hiding this comment.
sandbox probably shouldn't need to useFakeServer anymore. Also it looks like the adUnit (a few dozen lines above this comment, so github won't let me put a comment there) is unused now.
8 tasks
dbemiller
approved these changes
Oct 11, 2017
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Oct 18, 2017
* tag '0.31.0' of https://github.com/prebid/Prebid.js: (54 commits) Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645) Prebid 0.31.0 Release Support native click tracking (prebid#1691) Initial commit for video support for pbs (prebid#1706) Fixes: Immediate adapter response may end auction (prebid#1690) Rubicon feature/s2s test module (prebid#1678) Renaming of "huddledmasses" adapter into colossusssp (prebid#1701) Don't set non-object configurations (prebid#1704) Update JSDoc for `pbjs.enableAnalytics` (prebid#1565) Add ad units event (prebid#1702) AppnexusAst adapter: logging error message from endpoint (prebid#1697) AppnexusAst bidadapter markdown file (prebid#1696) Change Default Content-Type for POST Requests to 'application/json' (prebid#1681) Code improvement for trustx adapter (prebid#1673) PulsePoint Lite adapter - Enabling Sync pixel (prebid#1686) Update spotx video adapter to set the spotx_ad_key used in DFP (prebid#1614) Fix broken AOL mobile endpoint secure bid requests (prebid#1684) Fix adapter tests that hardcoded pbjs. (prebid#1666) no longer attaching gpt slots to adUnits, which breaks utils.cloneJson(adUnit) (prebid#1676) remove bidmanager from rubicon tests (prebid#1671) ...
mattpr
pushed a commit
to mattpr/Prebid.js
that referenced
this pull request
Oct 31, 2017
* remove bidmanager from rubicon tests * updated rubicon tests to not use callBids * remove no longer used artifacts from rubiconBidAdapter_spec
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* remove bidmanager from rubicon tests * updated rubicon tests to not use callBids * remove no longer used artifacts from rubiconBidAdapter_spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Removing all references of the bidManager from the rubicon tests to be 1.0 compatible.