Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #1628 (allowing standard bidCpmAdjustment) #1645

Merged
merged 2 commits into from
Oct 17, 2017
Merged

Fix for #1628 (allowing standard bidCpmAdjustment) #1645

merged 2 commits into from
Oct 17, 2017

Conversation

dugwood
Copy link
Contributor

@dugwood dugwood commented Sep 30, 2017

Type of change

  • Bugfix
  • Feature

Description of change

This is a fix to cover the documentation misleading «standard» bid adjustment function. See #1628.
Changed 1 test (to show that when the function is declared at the standard level, it doesn't impact the one declared at the bidder level) and added another one to show it's been taken into account.

Also I've patched the getStandardBidderSettings which would destroy the bidderSettings whenever the adserverTargeting wasn't found. It passes the tests without modification.

@mkendall07
Copy link
Member

nice! Will check it out later today

@mkendall07 mkendall07 self-assigned this Oct 3, 2017
@mkendall07
Copy link
Member

@rmloveland possible that this needs a docs revision if there is inconsistent references.

@jaiminpanchal27 jaiminpanchal27 merged commit e74ea2a into prebid:master Oct 17, 2017
@jaiminpanchal27 jaiminpanchal27 mentioned this pull request Oct 18, 2017
Closed
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Oct 18, 2017
Merge tag '0.31.0' of https://github.com/prebid/Prebid.js into prebuilt
67b5f38 
* tag '0.31.0' of https://github.com/prebid/Prebid.js: (54 commits)
  Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645)
  Prebid 0.31.0 Release
  Support native click tracking (prebid#1691)
  Initial commit for video support for pbs (prebid#1706)
  Fixes: Immediate adapter response may end auction (prebid#1690)
  Rubicon feature/s2s test module (prebid#1678)
  Renaming of "huddledmasses" adapter into colossusssp (prebid#1701)
  Don't set non-object configurations (prebid#1704)
  Update JSDoc for `pbjs.enableAnalytics` (prebid#1565)
  Add ad units event (prebid#1702)
  AppnexusAst adapter: logging error message from endpoint (prebid#1697)
  AppnexusAst bidadapter markdown file (prebid#1696)
  Change Default Content-Type for POST Requests to 'application/json' (prebid#1681)
  Code improvement for trustx adapter (prebid#1673)
  PulsePoint Lite adapter - Enabling Sync pixel (prebid#1686)
  Update spotx video adapter to set the spotx_ad_key used in DFP (prebid#1614)
  Fix broken AOL mobile endpoint secure bid requests (prebid#1684)
  Fix adapter tests that hardcoded pbjs. (prebid#1666)
  no longer attaching gpt slots to adUnits, which breaks utils.cloneJson(adUnit) (prebid#1676)
  remove bidmanager from rubicon tests (prebid#1671)
  ...
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Oct 25, 2017
Merge branch 'master' of https://github.com/prebid/Prebid.js
ec7c583 
* 'master' of https://github.com/prebid/Prebid.js: (414 commits)
  Make response headers available to the specs (prebid#1748)
  add option to run tests in a specific file (prebid#1727)
  Update JCM Adapter to 1.0  (prebid#1715)
  Finished an unfinished comment. (prebid#1749)
  Platform.io Bidder Adapter update.  Prebid v1.0. (prebid#1705)
  Fix window.top.host cross origin issue when in nested iframes. (prebid#1730)
  fix log message not displaying when referencing missing bidder (prebid#1737)
  Allow more than one placement from one page (prebid#1692)
  Justpremium Adapter bugfix (prebid#1716)
  Updating license (prebid#1717)
  realvuBidAdapter  (prebid#1571)
  Update JSDoc to call the module `pbjs` (prebid#1572)
  Update Beachfront adapter for v1.0 (prebid#1675)
  Update AdButler adapter for Prebid v1.0 (prebid#1664)
  Increment pre version
  Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645)
  Prebid 0.31.0 Release
  Support native click tracking (prebid#1691)
  Initial commit for video support for pbs (prebid#1706)
  Fixes: Immediate adapter response may end auction (prebid#1690)
  ...
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request Oct 30, 2017
@vzhukovsky
Merge pull request prebid#130 in AOLP_ADS_JS/prebid.js from release/1…
279bbae 
….31.0 to aolgithub-master

* commit 'e7341c948014a789084849495171d08d4b353d07': (21 commits)
  Added changelog entry.
  Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645)
  Prebid 0.31.0 Release
  Support native click tracking (prebid#1691)
  Initial commit for video support for pbs (prebid#1706)
  Fixes: Immediate adapter response may end auction (prebid#1690)
  Rubicon feature/s2s test module (prebid#1678)
  Renaming of "huddledmasses" adapter into colossusssp (prebid#1701)
  Don't set non-object configurations (prebid#1704)
  Update JSDoc for `pbjs.enableAnalytics` (prebid#1565)
  Add ad units event (prebid#1702)
  AppnexusAst adapter: logging error message from endpoint (prebid#1697)
  AppnexusAst bidadapter markdown file (prebid#1696)
  Change Default Content-Type for POST Requests to 'application/json' (prebid#1681)
  Code improvement for trustx adapter (prebid#1673)
  PulsePoint Lite adapter - Enabling Sync pixel (prebid#1686)
  Update spotx video adapter to set the spotx_ad_key used in DFP (prebid#1614)
  Fix broken AOL mobile endpoint secure bid requests (prebid#1684)
  Fix adapter tests that hardcoded pbjs. (prebid#1666)
  no longer attaching gpt slots to adUnits, which breaks utils.cloneJson(adUnit) (prebid#1676)
  ...
mattpr pushed a commit to mattpr/Prebid.js that referenced this pull request Oct 31, 2017
@dugwood @mattpr
Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645)
6bbd516 
* Added standard bidCpmAdjustment

* Fix missing «typeof»
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@dugwood @dluxemburg
Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645)
8976758 
* Added standard bidCpmAdjustment

* Fix missing «typeof»
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

Assignees

@mkendall07 mkendall07

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dugwood @mkendall07 @jaiminpanchal27 @matthewlane