Update JCM Adapter to 1.0 #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for jcm adapter
dbemiller
reviewed
Oct 18, 2017
adapters.json
Outdated
| @@ -0,0 +1,34 @@ | |||
| [ | |||
There was a problem hiding this comment.
File committed accidentally?
package.json
Outdated
| @@ -11,13 +11,15 @@ | |||
| "type": "git", | |||
| "url": "https://github.com/prebid/Prebid.js.git" | |||
| }, | |||
|
|
|||
There was a problem hiding this comment.
More unintended changes?
There was a problem hiding this comment.
There should be no changes to package.json or adapters.json in this PR.
There was a problem hiding this comment.
ok. Please remove them when you update, then
| expect(bidObj).to.have.property('callbackId').and.to.equal('3c9408cdbf2f68'); | ||
| it('sends bid request to ENDPOINT via GET', () => { | ||
| const request = spec.buildRequests(bidRequests); | ||
| expect(request.method).to.equal('GET'); |
There was a problem hiding this comment.
Needs some real assertions... barely tests buildRequests at all.
There was a problem hiding this comment.
Will look into this.
|
|
|
Our servers required an update. The test ad request should now deliver an ad. |
|
nope... still getting the same error |
|
Please retest the ad request. The cross-origin issue is resolved. |
dbemiller
approved these changes
Oct 23, 2017
jaiminpanchal27
approved these changes
Oct 24, 2017
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Oct 25, 2017
* 'master' of https://github.com/prebid/Prebid.js: (414 commits) Make response headers available to the specs (prebid#1748) add option to run tests in a specific file (prebid#1727) Update JCM Adapter to 1.0 (prebid#1715) Finished an unfinished comment. (prebid#1749) Platform.io Bidder Adapter update. Prebid v1.0. (prebid#1705) Fix window.top.host cross origin issue when in nested iframes. (prebid#1730) fix log message not displaying when referencing missing bidder (prebid#1737) Allow more than one placement from one page (prebid#1692) Justpremium Adapter bugfix (prebid#1716) Updating license (prebid#1717) realvuBidAdapter (prebid#1571) Update JSDoc to call the module `pbjs` (prebid#1572) Update Beachfront adapter for v1.0 (prebid#1675) Update AdButler adapter for Prebid v1.0 (prebid#1664) Increment pre version Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645) Prebid 0.31.0 Release Support native click tracking (prebid#1691) Initial commit for video support for pbs (prebid#1706) Fixes: Immediate adapter response may end auction (prebid#1690) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
-- [ ] Other
Description of change
Update JCM adapter for 1.0 compatability