-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Ad4Game adapter for Prebid.js 1.0 #1797
Conversation
Hi @matthewlane. I created new PR from (#1650). About response, you should use real domain instead of localhost when you testing. In my case I use Thank you |
hey @adilets, could you add a note about this in your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm able to receive bid responses from your endpoint after rewriting localhost to the test domain. This uncovered a problem with bid id matching but I've noted a fix for this below
const bidResponses = []; | ||
utils._each(serverResponses.body, function(response) { | ||
const bidResponse = { | ||
requestId: request.bidId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
request
is whatever was returned from the buildRequests
function, which currently isn't returning a bidId
. This causes the bids for your adapter to not get matched up, making it appear there was no bid response even though your endpoint is successfully returning bids. Make sure to make bidId
available so that this will work, see other comment for possible approaches
|
||
return { | ||
method: 'GET', | ||
url: deliveryUrl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One way to do it is to add bidId
to this object, and set it's value to the bid id of validBidRequests
(bidId: validBidRequests[0] && validBidRequests[0].bidId
in that case). Then bidId
will be available on the request
parameter in interpretResponse
and line 61 will work without modification. You can do it however you'd prefer though
] | ||
} | ||
]; | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a note about rewriting localhost to the test domain in order to receive bids
@matthewlane Thanks for your review and comments. I updated PR. |
Type of change
Description of change
Adding new bidder adapter for A4G
Be sure to test the integration with your adserver using the Hello World sample page.
Other information