A4G prebid adapter

[adilets]

Type of change

• Bugfix
• Feature
• [ x] New bidder adapter https://github.com/prebid/prebid.github.io/pull/333/files
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other

Description of change

Adding new bidder adapter for A4G

• test parameters for validating bids

{
  bidder: 'a4g',
  params: {
    zoneId: 59304,
    deliveryUrl: 'http://dev01.ad4game.com/v1/bid'
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer: adilet@ad4game.com, jaafar@ad4game.com, tech@ad4game.com
• official adapter submission

Other information

[matthewlane]

This adapter should be updated to be compliant with the upcoming 1.0 conventions. See http://prebid.org/dev-docs/bidder-adapter-1.html for information about this. Thanks for the PR

[adilets]

@matthewlane could you please review my code. Where should I change ? Thanks

[matthewlane]

@adilets Looks good, thanks for updating this to 1.0 conventions. There were a few breaking changes to master for 1.0 adapters recently, I noted fixes for them below.

Also, for testing bid responses, I'm getting a CORS error on your endpoint:

Failed to load http://dev01.ad4game.com/v1/bid?siteurl=http%3A%2F%2Fprebid.localhost%3A9999%2FintegrationExamples%2Fgpt%2Fbidder-test.html&size=300x250%2C320x50&id=&zoneId=59304&: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://prebid.localhost:9999' is therefore not allowed access.

There was a similar issue in #1627, so potentially this is because I'm testing from localhost. Let me know if that's the case or if there are other ways of validating bids from your endpoint, thanks

[matthewlane]

bidderCode can be dropped from the bid response object, it'll be set automatically by bidderFactory. Docs just updated, sorry for the confusion

[matthewlane]

#1748 changed the first argument of interpretResponse to:

{
  body: responseBody,
  headers: {
    get: function(header) { /* returns a header from the HTTP response */ }
  }
}

so updating serverResponses to serverResponses.body (and in corresponding tests if needed) should do the trick. May need to rebase off of master first

[adilets]

Hello matthewlane. I have updated my PR. I checked my server and resolved your comment messages.

[adilets]

@matthewlane I rebased to master. Maybe should I create new PR ?

[matthewlane]

Yeah, feel free to create a new PR. I think the changes look ok, but somehow it's showing that 105 files were changed. If you're able to figure out what's going on there you can push again to this PR but if it's easier, creating a new one with just your adapter is fine too and I'll finish the review there.

Also, still getting the same CORS error as above when testing the adapter. What I'm doing is taking the a4g params from the .md file and putting them on the hello_world test page, running gulp serve, and opening the page in a browser. The CORS error appears in the dev console and checking pbjs.getBidResponses() in the there shows a statusMessage of "Bid returned empty or error response" for a4g. Are you getting different results in this setup?