Added YIELDONE Bid Adapter for Prebid.js 1.0

[takuhou]

Type of change

• New bidder adapter

Description of change

New bidder adapter added for YIELDONE

• test parameters for validating bids

{
  bidder: 'yieldone',
  params: { 
    placementId: '44082'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer y1dev@platform-one.co.jp
• official adapter submission

[jsnellbaker]

Hello @takuhou, Thanks for submitting these changes. Overall everything appears to be in good shape.

The only question I had was around the test param data. The initial submission comment gave one placementId that worked occasionally for me (is there some cookie frequency capping in place?), but the param data in the md file didn't work. I was consistently getting Bid returned empty or error response response from your server.

Can you double-check this test param data and adjust it so we have something consistently coming back for testing? Whatever is the ideal set of data to use, that's the one which should be marked in the md file.

Thanks.

[takuhou]

Hello jsnellbaker

I'm sorry. Since it was setting retargeting, it was not delivered.
Please check again.

[jsnellbaker]

Hello @takuhou Thanks for making the change. I checked the test placement with the 44082 and it's working consistently now. However the test placement 44084 (the one that's provided in the .md file) still isn't working for me. Was that supposed to be fixed as well?

Alternatively if you want to use 44082 for overall testing, can you update the md file?

[takuhou]

Hello jsnellbaker

I changed placementId to 44082.
Please check again.

Thanks.

[takuhou]

Hello jsnellbaker

CI seems to have failed, but do you know why?
Do I need to fix something?

Thanks.

[jsnellbaker]

@takuhou Thanks for the change. I restarted the Travis build and it seems to have passed this time. Everything looks good now from my end.

[mkendall07]

why do you need repeat width/height params when you can get this off the bid.sizes?

[mkendall07]

@takuhou
everything looks good except for the width/height. Can you comment on that?

[takuhou]

Hello @mkendall07

This width and height are basically used as parameters when requesting to the server, specifying the size of the inventory.

There are special cases and you may distribute multiple size inventory to 300x250 inventory.
For example, 300 x 225 ads may be delivered at 300 x 250 inventory. At that time, have you specify width: 300 / height: 225.For that reason, we have width and height parameters as YIELDONE.

[mkendall07]

so in your example, 300x225 is an extra size that can deliver in addition to the 300x250 right? but it doesn't look like you read the adUnit sizes at all, so you only pass 300x225 to your endpoint...

[takuhou]

Hello @mkendall07

Well. Explanation is difficult.
OK. In HB in Prebid.js this case may not exist, so change it to take size from bid.

Please wait as it fixes.

Thanks.

[takuhou]

Hello @mkendall07

I fixed it, so please check it.

[mkendall07]

this won't work with multi size arrays. Example sizes = [[300,250], [728,90]]

take a look at https://github.com/prebid/Prebid.js/blob/master/src/utils.js#L113 for help with parsing.

[takuhou]

Hello @mkendall07

Please tell me what kind of case is multi-size with same Placement ID.

[mkendall07]

you don't have to read multiple sizes if you dont want, but you should take the first size if it's multiple.

[takuhou]

Hello @mkendall07

I fixed it, so please check it.

[takuhou]

Hello @mkendall07

Correspondence of bids.sizes is completed, please confirm.

Thanks.

[mkendall07]

This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing