Upgrade Admixer adapter for Prebid 1.0

[Galphimbl]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other

Description of change

• test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
• official adapter submission

Other information

[jsnellbaker]

Most of the changes for this 1.0 update look good, there are a few points that should be looked at however. Also, when I was testing with the params in the .md file - I wasn't getting any bids back from your server. I was receiving empty responses.

If there are any special notes needed to get back a test bid (e.g. "emulate a mobile device" or "make sure localhost isn't in your URL"), please add them to the .md. Otherwise, if it's a server bug or if the param data needs to be altered, please let me know when it's fixed/updated so I can test again.

[jsnellbaker]

This bidderCode param should be removed, it could cause issues if left in place.

[jsnellbaker]

Any errors that are caught during this part should be logged. They can be passed to the utils.logError() method.

[jsnellbaker]

If this getUserSyncs is not going to be actively used by the adapter, it does not need to be defined and can be removed.

[mkendall07]

no need for id here

[jsnellbaker]

#1748 changed the first argument of interpretResponse to:

{
  body: responseBody,
  headers: {
    get: function(header) { /* returns a header from the HTTP response */ }
  }
}

so adding something like

serverResponse = serverResponse.body;

just below this line, or however you'd prefer to grab the body, and updating corresponding tests if needed should get this back to working properly

[Galphimbl]

Now with the params in the .md file you may run tests from any url.

[jsnellbaker]

@Galphimbl Thanks for submitting an update. It seems like there are currently some conflicts between the current state of the PR and the master branch. Could you please review and resolve these conflicts? Thanks.

[Galphimbl]

@jsnellbaker Conflicts resolved

[jsnellbaker]

@Galphimbl Thanks for the confirmation and for submitting the changes.

I was retesting everything just one last time and I saw that the test information 300x250 banner is returning an empty response from your system. But on a related note, I saw that using the same zone param but with a 300x600 size - I was consistently getting an ad unit back and it was rendering fine on the hello_world.html test page.

Are you seeing similar behavior on your end? Ideally the test information within the .md file should contain working test ads.

Could you either review the 300x250 test ad unit? Or if you're fine with using a 300x600 banner unit for testing, could you update the .md file with the 300x600 test information?

Thanks.

[Galphimbl]

@jsnellbaker Thanks for reply.
Test profile was out of date, our managers have restarted it already.
No changes needed in .md file.

[jsnellbaker]

@Galphimbl Thanks for the update and for reactivating the test. The 300x250 banner is showing fine now. LGTM

[rmloveland]

Added the needs-docs label since it's not showing up on http://prebid.org/download.html in the 1.2.0 dropdown due to lack of the page having the "prebid 1.0 support" key in the page's YAML header.

Let me know if there is another better way to do this.