Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0 adapter support for mantis #1840

Merged
merged 3 commits into from
Jan 22, 2018
Merged

1.0 adapter support for mantis #1840

merged 3 commits into from
Jan 22, 2018

Conversation

parisholley
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

@ndhimehta ndhimehta assigned idettman and unassigned ndhimehta Nov 16, 2017
idettman
idettman reviewed Nov 20, 2017
View reviewed changes
modules/mantisBidAdapter.js Outdated
var val = data[key];
function isSecure() {
return document.location.protocol === 'https:';
}

Copy link
Contributor

@idettman idettman Nov 20, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: There is a function for testing types included in utils.js beginning on line #332. Line #334 includes an "isArray" method where you can see how the "isA" method could be used for testing types not included such as "[Object]".

@mkendall07
Copy link
Member

@idettman what's the status on this one?

@mkendall07
Copy link
Member

@parisholley
Please resolve the conflicts.

@mkendall07
Copy link
Member

@parisholley
needs rebasing before this can be merged.

@parisholley
Copy link
Contributor Author

@mkendall07 done

mkendall07
mkendall07 requested changes Jan 10, 2018
View reviewed changes
modules/mantisBidAdapter.js Outdated
}
}
if (!sync) {
postMessage('uuid', uuid);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the purpose of the postMessage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkendall07 this was common code for frame syncing for our non-prebid code, build now removes it. thanks

modules/mantisBidAdapter.js Outdated
return serverResponse.body.ads.map(function (ad) {
return {
requestId: ad.bid,
bidderCode: spec.code,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop this line. We add the code automatically from the spec, and it breaks aliasing if this is here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkendall07 done

@mkendall07
Copy link
Member

hey @parisholley
LGTM. Just needs a corresponding docs PR to merge: Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page.

@parisholley
Copy link
Contributor Author

@mkendall07 done, thanks!

prebid/prebid.github.io#546

@ghost ghost assigned matthewlane Jan 22, 2018
@ghost ghost added the in progress label Jan 22, 2018
@matthewlane matthewlane merged commit 25f1e5a into prebid:master Jan 22, 2018
@ghost ghost removed the in progress label Jan 22, 2018
@matthewlane matthewlane mentioned this pull request Jan 22, 2018
Merged
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Jan 23, 2018
Merge branch 'master' of https://github.com/prebid/Prebid.js
81cd86e 
* 'master' of https://github.com/prebid/Prebid.js: (23 commits)
  Update Atomx adapter for Prebid v1.0 (prebid#2026)
  Add vi bid adapter (prebid#2020)
  Add eplanningBidAdapter (prebid#2003)
  OpenX Adapter: Update to support mediaTypes field, instead of the deprecated mediaType field (prebid#1974)
  Separate bids & won calls (prebid#2015)
  1.0 adapter support for mantis (prebid#1840)
  Media.net adapter added (prebid#2038)
  GumGum Adapter for Prebid.js 1.0 (prebid#1966)
  Serverbid Bid Adapter: updated docs and ad sizes (prebid#2023)
  Adding districtm as an alias (prebid#2018)
  Use sudo to workaround Travis regression (prebid#2041)
  Fix uncached video bids triggering callback early (prebid#2017)
  Re-implemented RhythmOne audit beacon in prebid 1.0 interface (prebid#1953)
  Add NasmediaAdmixer adapter for Perbid.js 1.0 (prebid#1937)
  Update Adform adapter to Prebid v1.0 (prebid#1947)
  Upgrade Admixer adapter for Prebid 1.0 (prebid#1755)
  multiformat size validation checks (prebid#1964)
  Gjirafa Bidder Adapter (prebid#1944)
  pin gulp-connect at non-broken version (prebid#2008)
  Added dynamic ttl property for One Display and One Mobile. (prebid#2004)
  ...
@rmloveland
Copy link
Contributor

Added the needs-docs label since it's not showing up on http://prebid.org/download.html in the 1.2.0 dropdown due to lack of the page having the "prebid 1.0 support" key in the page's YAML header.

dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@parisholley @dluxemburg
1.0 adapter support for mantis (prebid#1840)
82bdb90 
* 1.0 support for mantis adapter

* removed some common non-prebid code

* Remove bidderCode to fix failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

@idettman idettman idettman approved these changes

Assignees

@idettman idettman

@matthewlane matthewlane

Labels
LGTM needs update Prebid 1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@parisholley @mkendall07 @rmloveland @idettman @matthewlane @jaiminpanchal27 @ndhimehta