Fix uncached video bids triggering callback early #2017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes a bug where auctions for video bids with cache enabled would execute the prebid callback handler on the first bid response, rather than waiting for all bids to be back. Does this by marking the
doneCbCallCount
property of cach-enabled video bids only after they've been cached server-side, rather than immediately on bid response.To test manually, create a test page with the following ad unit ('appnexusAst' is an alias of 'appnexus'). On master, search for
auctionEnd
in the dev console and notice abidResponse
comes after this event. On this fix,auctionEnd
comes after allbidResponse
s