Optimera Adapter for 1.0. #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewlane
approved these changes
Dec 19, 2017
mkendall07
requested changes
Jan 8, 2018
modules/optimeraBidAdapter.js
Outdated
| if (typeof validBids[i].params.custom.clientID != 'undefined') { | ||
| if (validBids[i].adUnitCode in scores) { | ||
| dealId = scores[validBids[i].adUnitCode]; | ||
| if (typeof serverResponse.body != 'undefined') { |
modules/optimeraBidAdapter.js
Outdated
| if (validBids[i].adUnitCode in scores) { | ||
| dealId = scores[validBids[i].adUnitCode]; | ||
| if (typeof serverResponse.body != 'undefined') { | ||
| var scores = serverResponse.body; |
modules/optimeraBidAdapter.js
Outdated
| if (typeof serverResponse.body != 'undefined') { | ||
| var scores = serverResponse.body; | ||
| for (var i = 0; i < validBids.length; i++) { | ||
| if (typeof validBids[i].params.custom.clientID != 'undefined') { |
There was a problem hiding this comment.
not safe access to clientID (in case custom is undefined`)
modules/optimeraBidAdapter.md
Outdated
| { | ||
| bidder: 'optimera', | ||
| params: { | ||
| custom:{ |
There was a problem hiding this comment.
why do you have the custom wrapper here? seems unnecessary.
There was a problem hiding this comment.
Ok, we removed the custom wrapper and updated the adapter and tests to reflect the change.
|
To merge this we need a docs PR. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing |
mkendall07
approved these changes
Jan 23, 2018
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Jan 24, 2018
* 'master' of https://github.com/prebid/Prebid.js: Prebid 1.2.0 Release Use polyfilled includes method (prebid#2061) RockYou Adapter: Added RockYou Adapter supporting Prebid 1.0 (prebid#1977) Optimera Adapter for 1.0. (prebid#1961) Use cross-browser integer check (prebid#2058) Fix skipped test (prebid#2059) Support multiple media formats within a single ad unit (prebid#1991) pre1api module that allows use of deprecated pre1.0 API in Prebid 1.0 (prebid#1976) Colossus SSP header bidding adapter 1.0.0 (prebid#2029) InSkin Bidder Adapter (prebid#2016) Update adapter to prebid v1.0 (prebid#1908) PubMatic 1.0 adapter (prebid#2011)
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Optimera Adapter for 1.0. * Optimera Adapter updating for json endpoint. * Optimera Adapter removing custom params property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Type of issue
Feature Request
Description
Adding Optimera's bid adapter for public use. Optimera's technology allows publishers to target viewability data to automate viewability optimization for any line item or PMP. Optimera does not push bids but instead targeting data via the deal ID space.
test parameters for validating bids
hb_deal_optimera=RB_K,300x250K,300x600K&hb_size_optimera=0x0&hb_pb_optimera=0.00&hb_adid_optimera=86a7b6905fe174&hb_bidder_optimera=optimera
An additional script must be added to the footer, contact Optimera for more information
contact email of the adapter’s maintainer
kcandiotti@optimera.nyc
Other information
Test Page:
http://optimera.elasticbeanstalk.com/prebidDemoPage.php
@kcandiotti
Relates to PR: #1760
We added some clarification to buildRequests() explaining what the GET request is used for.