PubMatic 1.0 adapter #2011
Merged
PubMatic 1.0 adapter #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also changed surce of end-point to prebid-client from prebid-server
PubMatic one
removed method _processFloor and _processPmZoneId added const for undefined
added a small function to find domain from given url
…changed to false, test cases updated
mkendall07
requested review from
jsnellbaker
and removed request for
jaiminpanchal27
9 tasks
|
@PubMatic-OpenWrap |
jsnellbaker
reviewed
Jan 10, 2018
There was a problem hiding this comment.
@PubMatic-OpenWrap Thanks for submitting this adapter. Overall the code looks good. There are some aspects/issues that I wanted to mention so we can be review/clarify them together.
I summarized them below:
- There are some areas with either extra comments or old code that was commented. Can these be reviewed/cleaned up if possible?
- It seems like to test the adapter, the userSync needs to be configured. I know this was highlight in the docs PR, but can we add this note in the md file in this PR as well so that the requirement is stated in a consistent manner?
- When I was testing the code with the test param data on the hello_world.html page, I saw the request to your system was formatted and executed but I wasn't getting any type of response back. The POST request indicated it had a 204 success code. As a result, I was only ever seeing a house ad return. Could you take a look on your end in regards to this request/response?
Thanks.
modules/pubmaticBidAdapter.js
Outdated
| // istanbul ignore else | ||
| if (CUSTOM_PARAMS.hasOwnProperty(key)) { | ||
| value = params[key]; | ||
| // istanbul ignore else |
There was a problem hiding this comment.
Are these types of comments still needed? I assume they were part of the development process and wanted to confirm.
modules/pubmaticBidAdapter.js
Outdated
| return true; | ||
| } | ||
| return false; | ||
| // return !!(bid && bid.params && utils.isStr(bid.params.publisherId) && utils.isStr(bid.params.adSlot)); |
There was a problem hiding this comment.
Can we remove this comment if the earlier code is the planned/definite approach to perform the validation check?
|
We have removed unwanted comments. |
|
@PubMatic-OpenWrap Thanks for making the updates. I used the updated test credentials and I saw the test ad deliver fine. LGTM |
mkendall07
approved these changes
Jan 23, 2018
| return conf; | ||
| } | ||
|
|
||
| function _createOrtbTemplate(conf) { |
There was a problem hiding this comment.
nice! Would be great if we had a community ORTB adapter at some point...
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Jan 24, 2018
* 'master' of https://github.com/prebid/Prebid.js: Prebid 1.2.0 Release Use polyfilled includes method (prebid#2061) RockYou Adapter: Added RockYou Adapter supporting Prebid 1.0 (prebid#1977) Optimera Adapter for 1.0. (prebid#1961) Use cross-browser integer check (prebid#2058) Fix skipped test (prebid#2059) Support multiple media formats within a single ad unit (prebid#1991) pre1api module that allows use of deprecated pre1.0 API in Prebid 1.0 (prebid#1976) Colossus SSP header bidding adapter 1.0.0 (prebid#2029) InSkin Bidder Adapter (prebid#2016) Update adapter to prebid v1.0 (prebid#1908) PubMatic 1.0 adapter (prebid#2011)
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* first commit * ip field removed, added comments to params, netRevenue set to true also changed surce of end-point to prebid-client from prebid-server * added _processFloor * removed comments * fixed unit test cases * review comments * added method _parseSlotParam removed method _processFloor and _processPmZoneId added const for undefined * minor changes * minor change * publisherId isStr check added * test case for string publisherId and adSlot * using prebid apis for getting pageURL and refURL, added a small function to find domain from given url * bid precision set to 2 * Added test cases for interpretResponse function * do not put warning for undefined valued params * changes for UOE-3239 and UOE-3236 * Linting errors fixed * Add geo object in device * Changes to trim kadpageurl and pmzoneid before sending it in request * Remove spaces when multiple Id's added in pmzoneId * rolling back changes for pmzoneid * Add PubMaticBidAdapter param info * Update params in pubmaticBidAdapter.md * Update maintainer mail-id * endpoint changed to hbopenbid.pubmatic.com, netRevenue default value changed to false, test cases updated * changed auction type to 1 * changed at to 1 in test cases * removed comments * UserSync requirements are mentioned in .md file * updated test ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information