Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sonobi Bidder Adapter For Prebid 1.x #2033

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

bansawbanchee
Copy link
Contributor

@bansawbanchee bansawbanchee commented Jan 15, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Update Sonobi Bid Adapter For Prebid 1.x

  • test parameters for validating bids
{
  bidder: "sonobi",
  params: {
    ad_unit: "/7780971/sparks_prebid_MR",
    sizes: [[300, 250], [300, 600]],
  }
}

Other information

@bansawbanchee bansawbanchee changed the title Adding Sonobi Bidder Adapter For Prebid 1.0 Update Sonobi Bidder Adapter For Prebid 1.x Jan 17, 2018
@bansawbanchee
Copy link
Contributor Author

@mike-chowla do we have a timeframe on when this adapter will get reviewed? Thanks!

@mike-chowla
Copy link
Contributor

@bansawbanchee Apologies for being slow on this. I'll look at it today

@mike-chowla
Copy link
Contributor

mike-chowla commented Jan 23, 2018

I'm not getting a bid back with the test parameters:

Request URL:
https://apex.go.sonobi.com/trinity.json?key_maker=%7B%22%2F7780971%2Fsparks_prebid_MR%7C21dfb9d577a57f%22%3A%22300x250%2C300x600%22%7D&ref=mike.pubmatic.com%3A9999&s=c65ebb7a-dd4c-4cfb-a108-b60db9469b34&

Request Headers:

Accept:*/*
Accept-Encoding:gzip, deflate, br
Accept-Language:en-US,en;q=0.9
Connection:keep-alive
Content-Type:text/plain
Cookie:__uin_ox=e1d0c80e-501b-4348-a4c4-29e92b2d1952; __uin_sv=c88cedb0cb1b18e599424da76d551245; _ga=GA1.2.1711484788.1512082199; __uin_mm=50b159ee-3f4e-4b00-aad9-44079453d8a0; __uin_an=2757055929694404700; __uin_gm=ChUIq4yl9rnm_vQ0ELK7yP3PvrGDmgESKAgNEiQyMmM4NDhlNy02MDdlLTQwNDMtYTY5ZC03MWM1ZGE1NTE4MmE=; __uin_tl=15964120476609789461; __uis=ebcb5bf7-b82d-11e7-99b6-000acd29f999; __uin_rx=RX-a64c4ee1-acf9-4fc5-9e91-b6229f7d7581; __uin_pp=LCt0jcoOpOgg; __uin_td=4d467a14-b169-42c7-bb32-5c991a43344e; __uig=["sonobi-semasio-21:1512172800:5184000","7c92015dab0f9576fe63::","sonobi-semasio-22:1512172800:5184000","sonobi-semasio-37:1512172800:5184000","sonobi-semasio-9:1515888000:5184000"]; __uin_bw=22c848e7-607e-4043-a69d-71c5da55182a; HAPLB3S=s3628|Wmdp8; HAPLB3A=s3624|Wmdqw
Host:apex.go.sonobi.com
Origin:http://mike.pubmatic.com:9999
Referer:http://mike.pubmatic.com:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true
User-Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Response Body:

{  
   "slots":{  
      "/7780971/sparks_prebid_MR|21dfb9d577a57f":{  

      }
   },
   "sbi_dc":"lax-1-",
   "sbi_px":[  
      {  
         "code":"ad",
         "delay":0,
         "url":"https://dpm.demdex.net/ibs:dpid=87880&dpuuid=ebcb5bf7-b82d-11e7-99b6-000acd29f999",
         "type":"image"
      }
   ]
}

@bansawbanchee
Copy link
Contributor Author

bansawbanchee commented Jan 23, 2018

Apologies. We setup a test campaign for you. It is now returning a test bid.

@mike-chowla
Copy link
Contributor

Test ad is displaying now

@mike-chowla mike-chowla self-requested a review January 25, 2018 00:25
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found!

Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please also submit a PR to update your bidder file in the docs repo, to add the line prebid_1_0_supported: true to the header, and make any updates to the bidder params if necessary

@mkendall07
Copy link
Member

@bansawbanchee
This PR is good to go but you need to submit an update to https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/sonobi.md before we can merge. Thanks

@bansawbanchee
Copy link
Contributor Author

Docs have been updated. prebid/prebid.github.io#589

@matthewlane matthewlane merged commit 53ab63d into prebid:master Feb 5, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants