-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sonobi Bidder Adapter For Prebid 1.x #2033
Conversation
158659f
to
aafcb7a
Compare
@mike-chowla do we have a timeframe on when this adapter will get reviewed? Thanks! |
@bansawbanchee Apologies for being slow on this. I'll look at it today |
I'm not getting a bid back with the test parameters: Request Headers:
Response Body:
|
Apologies. We setup a test campaign for you. It is now returning a test bid. |
Test ad is displaying now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please also submit a PR to update your bidder file in the docs repo, to add the line prebid_1_0_supported: true
to the header, and make any updates to the bidder params if necessary
@bansawbanchee |
Docs have been updated. prebid/prebid.github.io#589 |
Type of change
Description of change
Update Sonobi Bid Adapter For Prebid 1.x
Other information