Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sonobi Bidder Adapter Documentation #589

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

bansawbanchee
Copy link
Contributor

No description provided.

README.md Outdated
@@ -163,7 +163,7 @@ In alphabetical order:
+ Sahagun, Manny <msahagun@conversantmedia.com>
+ Tiffany Wu <twu@triplelift.com>
+ Vladimir Marteev <xor104@gmail.com>
+ astudnicky <astudnicky@sonobi.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to add your name to the list, but please don't remove the names of other contributors. This is taken from the git history.

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise LGTM

@bansawbanchee bansawbanchee force-pushed the sonobi-adapter-docs-update branch from b6e8a02 to 9578450 Compare February 5, 2018 16:18
@bansawbanchee
Copy link
Contributor Author

@rmloveland
I've rebased the change.

@bansawbanchee bansawbanchee force-pushed the sonobi-adapter-docs-update branch from 9578450 to 96b2615 Compare February 5, 2018 16:48
@rmloveland rmloveland added this to the Prebid 1.3 milestone Feb 6, 2018
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rmloveland rmloveland merged commit 61b687d into prebid:master Feb 13, 2018
@rmloveland
Copy link
Contributor

Should be showing up on the Downloads page soon, thanks @bansawbanchee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants