Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Adyoulike Adapter to prebid 1.0 #2077

Merged

Conversation

j343my
Copy link
Contributor

@j343my j343my commented Jan 28, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Version 1.0 of the Adyoulike Adapter, every mandatory params are the same as previous version

  • test parameters for validating bids
{
 bidder: 'adyoulike',
params: {
  placement: '194f787b85c829fb8822cdaf1ae64435'
  }
}

prebid/prebid.github.io#633

@mike-chowla
Copy link
Contributor

I'm not getting any bids back with the test parameters:
Request:

POST /hb-api/prebid/v1? HTTP/1.1
Host: hb-api.omnitagjs.com
Connection: keep-alive
Content-Length: 195
Pragma: no-cache
Cache-Control: no-cache
Origin: http://mike.pubmatic.com:9999
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36
Content-Type: text/plain
Accept: */*
Referer: http://mike.pubmatic.com:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true
Accept-Encoding: gzip, deflate
Accept-Language: en-US,en;q=0.9
Cookie: ayl_visitor=160181e842820164783b47b2e478da8a; __cfduid=d22ccaf4e1c3df8c26f7d1043c64de8771513983785
{  
   "Version":"1.0",
   "Bids":{  
      "25067855216796":{  
         "PlacementID":"194f787b85c829fb8822cdaf1ae64435",
         "TransactionID":"f9a1a143-df48-4571-9d81-58391bf60da4",
         "width":300,
         "height":250
      }
   },
   "PageRefreshed":true
}

Response Body:

[  
   {  
      "Price":0,
      "Attempt":"b1f53ae162abe30b194f787b85c829fb",
      "Placement":"194f787b85c829fb8822cdaf1ae64435",
      "Ad":"",
      "CreativeID":"b1f53ae162abe30b194f787b85c829fb",
      "BidID":"25067855216796"
   }
]

@j343my
Copy link
Contributor Author

j343my commented Feb 12, 2018

@mike-chowla could you try again?
normally now is OK

@mkendall07 mkendall07 added this to the Prebid 1.4.0 milestone Feb 12, 2018
@mike-chowla
Copy link
Contributor

Bid requests are failing due to a CORS issue:
screen shot 2018-02-12 at 4 16 50 pm

You can fix it by setting withCredentials to false

@@ -45,10 +45,16 @@ export const spec = {
       PageRefreshed: getPageRefreshed()
     };
     const payloadString = JSON.stringify(payload);
+
+    const options = {
+      withCredentials: false
+    };
+
     return {
       method: 'POST',
       url: createEndpoint(dcHostname),
       data: payloadString,
+      options: options
     };
   },
   /**

@j343my
Copy link
Contributor Author

j343my commented Feb 22, 2018

@mike-chowla I'm sorry for the delay.
I set withCredentials to false.

Could you test anew?

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will merge once documentation repo pull request is made

@j343my
Copy link
Contributor Author

j343my commented Feb 23, 2018

@mike-chowla
docs here:
prebid/prebid.github.io#633

thanks 😃

@mike-chowla mike-chowla merged commit 0ddebdf into prebid:master Feb 23, 2018
mizmaar3 added a commit to widespace-os/Prebid.js that referenced this pull request Feb 28, 2018
* master:
  Update Vertoz adapter for Prebid 1.0 (prebid#2104)
  Add multiple bids request  (prebid#2136)
  [NEW Adapter] RTBHouseBidAdapter (prebid#2184)
  Update Innity Adapter to Prebid.js v1.0 (prebid#2180)
  Update Adyoulike Adapter to prebid 1.0 (prebid#2077)
  Change bidderCode for DAN Marketplace Bid Adapter (prebid#2183)
  only count bid timeouts if bidder didn't call done. fixes prebid#2146 (prebid#2154)
  [Edit BidAdapter] rxrtb adapter for Perbid.js 1.0 (prebid#2182)
  Update NasmediaAdmixer adapter (prebid#2164)
  only do video caching if we don't already have a videoCacheKey (prebid#2143)
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* feat(adyoulikeAdapter): update adapter

* fix(payload): fix height and width request keys

* fix(Request): set credentials to false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants