Update Vertoz adapter for Prebid 1.0 #2104

mohit546 · 2018-02-05T09:21:49Z

    * Migrating to Prebid 1.0
    * spec added

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

test parameters for validating bids

{
  bidder: 'vertoz',
  params: {
    placementId: "VZ-HB-B784382V6C6G3C"
  }
}

* Migrating to Prebid 1.0 * spec added

matthewlane

Thanks for the PR, a few changes requested. Also, when testing this adapter with the test parameters, I'm getting a response of {"slotBidId":"274058c816c8fe","statusText":"Application_Error"} from the endpoint, please check and advise if these params are still valid for testing

matthewlane · 2018-02-13T17:20:24Z

modules/vertozBidAdapter.js

+
+export const spec = {
+ code: BIDDER_CODE,
+ aliases: [], // short code


If you don't have any aliases defined, this line can be dropped

matthewlane · 2018-02-13T17:20:56Z

modules/vertozBidAdapter.js

+ }
+ return bidResponses;
+ },
+ getUserSyncs: function (syncOptions, serverResponses) {


If you don't need any user syncing, this function can be removed

matthewlane · 2018-02-13T17:26:35Z

test/spec/modules/vertozBidAdapter_spec.js

+ expect(request.method).to.equal('POST');
+ });
+ });
+});


These tests are only providing 68.97% coverage of the adapter, we require at least 80% before merge. Removing the unneeded code mentioned in the other comments should bump the percentage up, and then testing the interpretResponse should help getting there

matthewlane · 2018-02-13T17:29:46Z

@mohit546 Please also submit a PR to the docs repo to update your adapter file to add prebid_1_0_supported: true to the header and update any bidder params as necessary

- removed unneeded code

matthewlane · 2018-02-15T17:43:48Z

Docs PR: prebid/prebid.github.io#616

matthewlane

Changes look good, tests now have great than 80% coverage. @mohit546 Still receiving {"slotBidId":"274058c816c8fe","statusText":"Application_Error"} when requesting test bids though, please check. Once we can validate bid responses this should be good for merge

Prebid-Vertoz · 2018-02-16T12:55:25Z

Hi @matthewlane,
Can you please share request here so that we can find more.
Because we are unable to create this issue on our side.

matthewlane · 2018-02-16T21:36:53Z

@Prebid-Vertoz Sure. After running gulp serve, and placing the vertoz params on the hello_world test page, the request I'm seeing to http://hb.vrtzads.com/vzhbidder/bid? is

{"q":"%7B%22_vzPlacementId%22%3A%22VZ-HB-B784382V6C6G3C%22%2C%22_rqsrc%22%3A%22http%3A%2F%2Flocalhost%3A9999%2FintegrationExamples%2Fgpt%2Fhello_world.html%22%2C%22_cb%22%3A1518816756%2C%22_slotBidId%22%3A%2223d814c7aad797%22%2C%22_cbn%22%3A%22pbjs%22%7D"}

and the response is

{"slotBidId":"23d814c7aad797","statusText":"Application_Error"}

Prebid-Vertoz · 2018-02-19T09:45:08Z

Hi @matthewlane,
Cause behind getting "Application Error" in response is "localhost:9999" in "_rqsrc" parameter.
This issue is arising because we are using a third party library for domain validation and it is not allowing
":" in domain.
Is it possible to test it with some valid domain to get a proper response?

matthewlane · 2018-02-20T19:14:10Z

@Prebid-Vertoz Moved my test page to a domain without a port in the domain, request is now

{"q":"%7B%22_vzPlacementId%22%3A%22VZ-HB-B784382V6C6G3C%22%2C%22_rqsrc%22%3A%22http%3A%2F%2Fmlane.devnxs.net%2Fvertoz%2F%22%2C%22_cb%22%3A1519153843%2C%22_slotBidId%22%3A%224f809a85a752f3%22%2C%22_cbn%22%3A%22pbjs%22%7D"}

and response is now

{"slotBidId":"4f809a85a752f3","statusText":"InvalidRequest"}

Please advise about this error. If you have a publicly available test page that requests and returns bids with this adapter I can check that as well

Prebid-Vertoz · 2018-02-21T07:36:05Z

@matthewlane , thanks for response. " http://filmgrapevine.com/prebid_test_page.html " this is a test page where bids are requested and returned from the adapter.

matthewlane · 2018-02-21T16:43:50Z

@Prebid-Vertoz Great, I'm able to access that page. Current response from Vertoz there is

{"vzhPlacementId":"VZ-HB-B784382V6C6G3C","slotBidId":"21613f3032bf11","statusText":"NO_BIDS"}

please check. As soon as I can verify a valid bid response rather than a no_bids response this should be good for merge

Prebid-Vertoz · 2018-02-23T10:48:09Z

Hi @matthewlane ,
Please check now. You should get a bid in return.

* master: Update Vertoz adapter for Prebid 1.0 (prebid#2104) Add multiple bids request (prebid#2136) [NEW Adapter] RTBHouseBidAdapter (prebid#2184) Update Innity Adapter to Prebid.js v1.0 (prebid#2180) Update Adyoulike Adapter to prebid 1.0 (prebid#2077) Change bidderCode for DAN Marketplace Bid Adapter (prebid#2183) only count bid timeouts if bidder didn't call done. fixes prebid#2146 (prebid#2154) [Edit BidAdapter] rxrtb adapter for Perbid.js 1.0 (prebid#2182) Update NasmediaAdmixer adapter (prebid#2164) only do video caching if we don't already have a videoCacheKey (prebid#2143)

mohit546 · 2018-03-09T11:02:57Z

@matthewlane ,
tried to download vertoz adaptor 1.4.0 from http://prebid.org/
got email

but getting following error on link

saw release notes
vertoz adaptor listed in 1.5.0, but not in 1.4.0

matthewlane · 2018-03-09T19:04:59Z

@mohit546 Thanks for letting me know, the docs pr was merged before the download page got updated for 1.5.0. I reverted the commit and will add it back once the page is updated and it should work properly then

mohit546 · 2018-05-28T11:49:37Z

@matthewlane i am not seeing vertoz adaptor in 1.12.0, and there is no option for 1.0.0. do i have to update adaptor for latest version ?

matthewlane · 2018-05-29T16:12:06Z

@mohit546 Sorry about that, re-reverted the docs in prebid/prebid.github.io#805 and Vertoz should be on the download page now

Update Vertoz adapter for Prebid 1.0

750ca2d

* Migrating to Prebid 1.0 * spec added

matthewlane added the needs review label Feb 6, 2018

matthewlane self-requested a review February 6, 2018 18:12

matthewlane self-assigned this Feb 6, 2018

mkendall07 added this to the Prebid 1.4.0 milestone Feb 12, 2018

matthewlane requested changes Feb 13, 2018

View reviewed changes

matthewlane added needs update not receiving bids and removed needs review labels Feb 13, 2018

matthewlane added the needs docs label Feb 13, 2018

Vertozbid adapter: spec updated

44ef36b

- removed unneeded code

matthewlane removed needs docs needs update labels Feb 15, 2018

matthewlane reviewed Feb 15, 2018

View reviewed changes

matthewlane removed this from the Prebid 1.4.0 milestone Feb 21, 2018

mkendall07 added this to the Prebid 1.5.0 milestone Feb 23, 2018

matthewlane approved these changes Feb 23, 2018

View reviewed changes

matthewlane added LGTM and removed not receiving bids labels Feb 23, 2018

matthewlane merged commit 9d55719 into prebid:master Feb 23, 2018

dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018

Update Vertoz adapter for Prebid 1.0 (prebid#2104)

2bcf62c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Vertoz adapter for Prebid 1.0 #2104

Update Vertoz adapter for Prebid 1.0 #2104

mohit546 commented Feb 5, 2018 •

edited

Loading

matthewlane left a comment

matthewlane Feb 13, 2018

matthewlane Feb 13, 2018

matthewlane Feb 13, 2018

matthewlane commented Feb 13, 2018 •

edited

Loading

matthewlane commented Feb 15, 2018

matthewlane left a comment

Prebid-Vertoz commented Feb 16, 2018

matthewlane commented Feb 16, 2018

Prebid-Vertoz commented Feb 19, 2018

matthewlane commented Feb 20, 2018

Prebid-Vertoz commented Feb 21, 2018 •

edited

Loading

matthewlane commented Feb 21, 2018

Prebid-Vertoz commented Feb 23, 2018

mohit546 commented Mar 9, 2018 •

edited

Loading

matthewlane commented Mar 9, 2018

mohit546 commented May 28, 2018 •

edited

Loading

matthewlane commented May 29, 2018

Update Vertoz adapter for Prebid 1.0 #2104

Update Vertoz adapter for Prebid 1.0 #2104

Conversation

mohit546 commented Feb 5, 2018 • edited Loading

Type of change

Description of change

matthewlane left a comment

Choose a reason for hiding this comment

matthewlane Feb 13, 2018

Choose a reason for hiding this comment

matthewlane Feb 13, 2018

Choose a reason for hiding this comment

matthewlane Feb 13, 2018

Choose a reason for hiding this comment

matthewlane commented Feb 13, 2018 • edited Loading

matthewlane commented Feb 15, 2018

matthewlane left a comment

Choose a reason for hiding this comment

Prebid-Vertoz commented Feb 16, 2018

matthewlane commented Feb 16, 2018

Prebid-Vertoz commented Feb 19, 2018

matthewlane commented Feb 20, 2018

Prebid-Vertoz commented Feb 21, 2018 • edited Loading

matthewlane commented Feb 21, 2018

Prebid-Vertoz commented Feb 23, 2018

mohit546 commented Mar 9, 2018 • edited Loading

matthewlane commented Mar 9, 2018

mohit546 commented May 28, 2018 • edited Loading

matthewlane commented May 29, 2018

mohit546 commented Feb 5, 2018 •

edited

Loading

matthewlane commented Feb 13, 2018 •

edited

Loading

Prebid-Vertoz commented Feb 21, 2018 •

edited

Loading

mohit546 commented Mar 9, 2018 •

edited

Loading

mohit546 commented May 28, 2018 •

edited

Loading